Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable-8] Fix the homebrew module failing because of warnings (#8406) #8429

Merged
merged 1 commit into from
Jun 1, 2024
Merged

[stable-8] Fix the homebrew module failing because of warnings (#8406) #8429

merged 1 commit into from
Jun 1, 2024

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

Manual backport of #8406 to stable-8.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

homebrew

@kustodian @felixfontein
Fix the homebrew module failing because of warnings (ansible-collecti…
b95e423 
…ons#8406)

Instead of checking if there is an error message, which can also be a
warning, we now check the return code.

This commit fixes ansible-collections#8229 ansible-collections#7044

Co-authored-by: Strahinja Kustudic <[email protected]>
(cherry picked from commit 43cb5a0)
@felixfontein felixfontein added the check-before-release PR will be looked at again shortly before release and merged if possible. label May 27, 2024
@felixfontein
Copy link
Collaborator Author

CC @kustodian @Israphel

@ansibullbot
Copy link
Collaborator

cc @Akasurde @andrew-d @danieljaouen @indrajitr @kyleabenson @martinm82
click here for bot help

@ansibullbot ansibullbot added backport bug This issue/PR relates to a bug module module plugins plugin (any type) labels May 27, 2024
@kustodian
Copy link
Contributor

Looks good xD

russoz
russoz approved these changes Jun 1, 2024
View reviewed changes
Copy link
Collaborator

@russoz russoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felixfontein felixfontein merged commit 03d944b into ansible-collections:stable-8 Jun 1, 2024
131 checks passed
@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Jun 1, 2024
@felixfontein felixfontein deleted the 8406 branch June 1, 2024 19:32
@felixfontein
Copy link
Collaborator Author

@kustodian @russoz thanks for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@russoz russoz russoz approved these changes

Assignees
No one assigned
Labels
backport bug This issue/PR relates to a bug module module plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@felixfontein @ansibullbot @kustodian @russoz