-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(opentelemetry): avoid storing inmemory if logs are disabled #8373
fix(opentelemetry): avoid storing inmemory if logs are disabled #8373
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
@v1v this PR contains the following merge commits: Please rebase your branch to remove these commits. |
Looks good to me! If nobody objects, I'll merge this this weekend. |
d87b9fe
into
ansible-collections:main
Backport to stable-7: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply d87b9fe on top of patchback/backports/stable-7/d87b9fe0dce577aad2e58f56626a5df50839a884/pr-8373 Backporting merged PR #8373 into main
🤖 @patchback |
@v1v thanks for your contribution! |
Backport to stable-8: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply d87b9fe on top of patchback/backports/stable-8/d87b9fe0dce577aad2e58f56626a5df50839a884/pr-8373 Backporting merged PR #8373 into main
🤖 @patchback |
…ble-collections#8373) * fix(opentelemetry): avoid storing inmemory if logs are disabled * changelog * fix syntax * refactor * chore * chore * chore * fix (cherry picked from commit d87b9fe)
…ble-collections#8373) * fix(opentelemetry): avoid storing inmemory if logs are disabled * changelog * fix syntax * refactor * chore * chore * chore * fix (cherry picked from commit d87b9fe)
…bled (#8373) (#8390) fix(opentelemetry): avoid storing inmemory if logs are disabled (#8373) * fix(opentelemetry): avoid storing inmemory if logs are disabled * changelog * fix syntax * refactor * chore * chore * chore * fix (cherry picked from commit d87b9fe) Co-authored-by: Victor Martinez <[email protected]>
…abled (#8373) (#8391) fix(opentelemetry): avoid storing inmemory if logs are disabled (#8373) * fix(opentelemetry): avoid storing inmemory if logs are disabled * changelog * fix syntax * refactor * chore * chore * chore * fix (cherry picked from commit d87b9fe) Co-authored-by: Victor Martinez <[email protected]>
…ble-collections#8373) * fix(opentelemetry): avoid storing inmemory if logs are disabled * changelog * fix syntax * refactor * chore * chore * chore * fix
…ble-collections#8373) * fix(opentelemetry): avoid storing inmemory if logs are disabled * changelog * fix syntax * refactor * chore * chore * chore * fix
SUMMARY
Workaround for #8353
Let's skip storing large datasets if the logs are disabled. This should help with the existing memory issues, so users can disable the logs. While we can figure out how to fix the underlying issue with storing large datasets.
ISSUE TYPE
COMPONENT NAME
plugins/callback/opentelemetry
ADDITIONAL INFORMATION