Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update lxd_container.py documentation. #8309

Merged
merged 1 commit into from
May 26, 2024
Merged

Update lxd_container.py documentation. #8309

merged 1 commit into from
May 26, 2024

Conversation

Herschdorfer
Copy link
Contributor

SUMMARY

Two small changes:

  • use APT module. The previous example would always return 'modified'
  • Remove Debian example. The example does not work anymore after https://linuxcontainers.org/ did drop LXD support.

trivial:

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

lxd_container

ADDITIONAL INFORMATION

none

@ansibullbot
Copy link
Collaborator

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

plugins/modules/lxd_container.py:242:27: W291: trailing whitespace

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

plugins/modules/lxd_container.py:242:27: W291: trailing whitespace

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

plugins/modules/lxd_container.py:242:27: W291: trailing whitespace

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

plugins/modules/lxd_container.py:242:27: W291: trailing whitespace

click here for bot help

@ansibullbot ansibullbot added ci_verified Push fixes to PR branch to re-run CI docs docs_only module module needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR plugins plugin (any type) labels May 5, 2024
@Herschdorfer Herschdorfer force-pushed the main branch 3 times, most recently from 4a36eb4 to 25848d1 Compare May 5, 2024 14:44
@Herschdorfer
Copy link
Contributor Author

Sorry for the force push mess.
I had my editor setup to auto-format and pushed that by accident.

@ansibullbot ansibullbot removed ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels May 5, 2024
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-7 backport-8 Automatically create a backport for the stable-8 branch labels May 5, 2024
felixfontein
felixfontein reviewed May 5, 2024
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@ansibullbot ansibullbot added the stale_ci CI is older than 7 days, rerun before merging label May 17, 2024
@felixfontein felixfontein added backport-9 Automatically create a backport for the stable-9 branch and removed backport-7 labels May 19, 2024
@ansibullbot ansibullbot added small_patch Hopefully easy to review and removed stale_ci CI is older than 7 days, rerun before merging labels May 25, 2024
@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label May 26, 2024
@felixfontein felixfontein merged commit d96b264 into ansible-collections:main May 26, 2024
132 checks passed
@patchback Patchback
Copy link

patchback bot commented May 26, 2024 •
edited
Loading

Backport to stable-8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-8/d96b2642bc25d5febaa136266b2f73ec0ea4bb6e/pr-8309

Backported as #8421

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein
Copy link
Collaborator

@Herschdorfer thanks!

patchback bot pushed a commit that referenced this pull request May 26, 2024
@Herschdorfer @patchback
Update lxd_container.py documentation. (#8309)
2a3f7c5 
remove dead link from debian example

(cherry picked from commit d96b264)
@patchback patchback bot mentioned this pull request May 26, 2024
Merged
@patchback Patchback
Copy link

patchback bot commented May 26, 2024 •
edited
Loading

Backport to stable-9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-9/d96b2642bc25d5febaa136266b2f73ec0ea4bb6e/pr-8309

Backported as #8422

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request May 26, 2024
@Herschdorfer @patchback
Update lxd_container.py documentation. (#8309)
4505f5b 
remove dead link from debian example

(cherry picked from commit d96b264)
@patchback patchback bot mentioned this pull request May 26, 2024
Merged
felixfontein pushed a commit that referenced this pull request May 26, 2024
@patchback @Herschdorfer
[PR #8309/d96b2642 backport][stable-9] Update lxd_container.py docume…
51ec359 
…ntation. (#8422)

Update lxd_container.py documentation. (#8309)

remove dead link from debian example

(cherry picked from commit d96b264)

Co-authored-by: Herschdorfer <[email protected]>
felixfontein pushed a commit that referenced this pull request May 26, 2024
@patchback @Herschdorfer
[PR #8309/d96b2642 backport][stable-8] Update lxd_container.py docume…
2ea8850 
…ntation. (#8421)

Update lxd_container.py documentation. (#8309)

remove dead link from debian example

(cherry picked from commit d96b264)

Co-authored-by: Herschdorfer <[email protected]>
Massl123 pushed a commit to Massl123/community.general that referenced this pull request Feb 7, 2025
@Herschdorfer @Massl123
Update lxd_container.py documentation. (ansible-collections#8309)
78cdd04 
remove dead link from debian example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
backport-8 Automatically create a backport for the stable-8 branch backport-9 Automatically create a backport for the stable-9 branch docs_only docs module module plugins plugin (any type) small_patch Hopefully easy to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Herschdorfer @ansibullbot @felixfontein