Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keycloak_realm: add normalizations for enabledEventTypes, and supportedLocales #8224

Merged
merged 1 commit into from
Apr 20, 2024
Merged

keycloak_realm: add normalizations for enabledEventTypes, and supportedLocales #8224

merged 1 commit into from
Apr 20, 2024

Conversation

yeoldegrove
Copy link
Contributor

SUMMARY

keycloak_realm: Add sorted defaultClientScopes and optionalClientScopes to normalizations.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

keycloak_realm

ADDITIONAL INFORMATION

Without this code, ansible-playbook --check --diffwill show changes because a unsorted list is diffed.
It uses the same approach as for keycloak_client in

community.general/plugins/modules/keycloak_client.py

Line 730 in 6c8f949

def normalise_cr(clientrep, remove_ids=False):

@yeoldegrove yeoldegrove force-pushed the keycloak_realm/add-normalizations branch from a97b096 to 34c3140 Compare April 15, 2024 13:26
@ansibullbot
Copy link
Collaborator

cc @eikef @kris2kris @mattock @ndclt
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug module module plugins plugin (any type) labels Apr 15, 2024
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-7 backport-8 Automatically create a backport for the stable-8 branch labels Apr 15, 2024
@felixfontein felixfontein changed the title keycloak_realm: add nomalizations for enabledEventTypes, and supportedLocales keycloak_realm: add normalizations for enabledEventTypes, and supportedLocales Apr 15, 2024
felixfontein
felixfontein reviewed Apr 15, 2024
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@yeoldegrove yeoldegrove force-pushed the keycloak_realm/add-normalizations branch from 34c3140 to 46f0ff1 Compare April 16, 2024 05:31
@yeoldegrove yeoldegrove force-pushed the keycloak_realm/add-normalizations branch from 46f0ff1 to a5a2169 Compare April 18, 2024 06:01
@ansibullbot ansibullbot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Apr 18, 2024
@felixfontein
Copy link
Collaborator

If nobody objects, I'll merge this on the upcoming weekend.

@ansibullbot ansibullbot removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Apr 18, 2024
@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Apr 20, 2024
@felixfontein felixfontein merged commit 9d66a1d into ansible-collections:main Apr 20, 2024
132 of 133 checks passed
@patchback Patchback
Copy link

patchback bot commented Apr 20, 2024 •
edited
Loading

Backport to stable-7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-7/9d66a1dc1e54c242c899fe1dc6c1ceab7871a894/pr-8224

Backported as #8255

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein
Copy link
Collaborator

@yeoldegrove thanks for this one as well!

patchback bot pushed a commit that referenced this pull request Apr 20, 2024
@yeoldegrove @patchback
keycloak_realm: add normalizations for enabledEventTypes, and support…
e8cc3b4 
…edLocales (#8224)

keycloak_realm: add nomalizations for enabledEventTypes, and supportedLocales

Signed-off-by: Eike Waldt <[email protected]>
(cherry picked from commit 9d66a1d)
@patchback patchback bot mentioned this pull request Apr 20, 2024
Merged
@patchback Patchback
Copy link

patchback bot commented Apr 20, 2024 •
edited
Loading

Backport to stable-8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-8/9d66a1dc1e54c242c899fe1dc6c1ceab7871a894/pr-8224

Backported as #8256

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Apr 20, 2024
@yeoldegrove @patchback
keycloak_realm: add normalizations for enabledEventTypes, and support…
0ee10e5 
…edLocales (#8224)

keycloak_realm: add nomalizations for enabledEventTypes, and supportedLocales

Signed-off-by: Eike Waldt <[email protected]>
(cherry picked from commit 9d66a1d)
@patchback patchback bot mentioned this pull request Apr 20, 2024
Merged
felixfontein pushed a commit that referenced this pull request Apr 21, 2024
@patchback @yeoldegrove
[PR #8224/9d66a1dc backport][stable-8] keycloak_realm: add normalizat…
a64098c 
…ions for enabledEventTypes, and supportedLocales (#8256)

keycloak_realm: add normalizations for enabledEventTypes, and supportedLocales (#8224)

keycloak_realm: add nomalizations for enabledEventTypes, and supportedLocales

Signed-off-by: Eike Waldt <[email protected]>
(cherry picked from commit 9d66a1d)

Co-authored-by: Eike Waldt <[email protected]>
felixfontein pushed a commit that referenced this pull request Apr 21, 2024
@patchback @yeoldegrove
[PR #8224/9d66a1dc backport][stable-7] keycloak_realm: add normalizat…
2583e39 
…ions for enabledEventTypes, and supportedLocales (#8255)

keycloak_realm: add normalizations for enabledEventTypes, and supportedLocales (#8224)

keycloak_realm: add nomalizations for enabledEventTypes, and supportedLocales

Signed-off-by: Eike Waldt <[email protected]>
(cherry picked from commit 9d66a1d)

Co-authored-by: Eike Waldt <[email protected]>
aretrosen pushed a commit to aretrosen/community.general that referenced this pull request Apr 22, 2024
@yeoldegrove @aretrosen
keycloak_realm: add normalizations for enabledEventTypes, and support…
2d6d00a 
…edLocales (ansible-collections#8224)

keycloak_realm: add nomalizations for enabledEventTypes, and supportedLocales

Signed-off-by: Eike Waldt <[email protected]>
Massl123 pushed a commit to Massl123/community.general that referenced this pull request Feb 7, 2025
@yeoldegrove @Massl123
keycloak_realm: add normalizations for enabledEventTypes, and support…
be99f4b 
…edLocales (ansible-collections#8224)

keycloak_realm: add nomalizations for enabledEventTypes, and supportedLocales

Signed-off-by: Eike Waldt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein Awaiting requested review from felixfontein

Assignees
No one assigned
Labels
backport-8 Automatically create a backport for the stable-8 branch bug This issue/PR relates to a bug module module plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yeoldegrove @ansibullbot @felixfontein