Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redfish: add Multipart bool return value to FirmwareUpdateCapabilities #8195

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

glimchb
Copy link
Contributor

@glimchb glimchb commented Apr 5, 2024

Fixed #8194

SUMMARY
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

@glimchb glimchb changed the title Redfish: add Multipart bool return value to FirmwareUpdateCapabilities Redfish: add Multipart bool return value to FirmwareUpdateCapabilities Apr 5, 2024
@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added feature This issue/PR relates to a feature request module_utils module_utils plugins plugin (any type) labels Apr 5, 2024
@glimchb
Copy link
Contributor Author

glimchb commented Apr 5, 2024

ready_for_review

@glimchb
Copy link
Contributor Author

glimchb commented Apr 5, 2024

this is how it looks today



2024-04-05 17:33:27     "redfish_facts": {
2024-04-05 17:33:27         "firmware_update_capabilities": {
2024-04-05 17:33:27             "entries": {
2024-04-05 17:33:27                 "#UpdateService.SimpleUpdate": [
2024-04-05 17:33:27                     "SCP"
2024-04-05 17:33:27                 ],
2024-04-05 17:33:27                 "Oem": [
2024-04-05 17:33:27                     "Key [email protected] not found"
2024-04-05 17:33:27                 ]
2024-04-05 17:33:27             },
2024-04-05 17:33:27             "multipart_supported": true,
2024-04-05 17:33:27             "ret": true
2024-04-05 17:33:27         }
2024-04-05 17:33:27     }

@glimchb
Copy link
Contributor Author

glimchb commented Apr 5, 2024

recheck

@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-8 Automatically create a backport for the stable-8 branch labels Apr 5, 2024
@mraineri
Copy link
Contributor

ship it

Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I missed this earlier...

@glimchb
Copy link
Contributor Author

glimchb commented Apr 11, 2024

Sorry, I missed this earlier...

no worries, added

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Apr 12, 2024
@felixfontein felixfontein merged commit 6c8f949 into ansible-collections:main Apr 12, 2024
132 of 133 checks passed
Copy link

patchback bot commented Apr 12, 2024

Backport to stable-8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-8/6c8f949ba950309931d8931f4820b99707898850/pr-8195

Backported as #8218

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Apr 12, 2024
…ties` (#8195)

* Redfish: add Multipart bool return value to FirmwareUpdateCapabilities

Fixes #8194

Signed-off-by: Boris Glimcher <[email protected]>

* Update changelogs/fragments/8194-redfish-add-multipart-to-capabilities.yml

Co-authored-by: Felix Fontein <[email protected]>

---------

Signed-off-by: Boris Glimcher <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit 6c8f949)
@felixfontein
Copy link
Collaborator

@glimchb thanks for your contribution!
@mraineri thanks for reviewing this!

felixfontein pushed a commit that referenced this pull request Apr 13, 2024
…return value to `FirmwareUpdateCapabilities` (#8218)

Redfish: add `Multipart` bool return value to `FirmwareUpdateCapabilities` (#8195)

* Redfish: add Multipart bool return value to FirmwareUpdateCapabilities

Fixes #8194

Signed-off-by: Boris Glimcher <[email protected]>

* Update changelogs/fragments/8194-redfish-add-multipart-to-capabilities.yml

Co-authored-by: Felix Fontein <[email protected]>

---------

Signed-off-by: Boris Glimcher <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit 6c8f949)

Co-authored-by: Boris Glimcher <[email protected]>
Massl123 pushed a commit to Massl123/community.general that referenced this pull request Feb 7, 2025
…ties` (ansible-collections#8195)

* Redfish: add Multipart bool return value to FirmwareUpdateCapabilities

Fixes ansible-collections#8194

Signed-off-by: Boris Glimcher <[email protected]>

* Update changelogs/fragments/8194-redfish-add-multipart-to-capabilities.yml

Co-authored-by: Felix Fontein <[email protected]>

---------

Signed-off-by: Boris Glimcher <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8 Automatically create a backport for the stable-8 branch feature This issue/PR relates to a feature request module_utils module_utils plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redfish: add MultipartHttpPushUri boolean return value to GetFirmwareUpdateCapabilities
4 participants