-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Ensuring interpolation is disabled for ConfigParser #8185
fix: Ensuring interpolation is disabled for ConfigParser #8185
Conversation
This PR disables interpolation of ConfigParser and adds test coverage for that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this!
Co-authored-by: Felix Fontein <[email protected]>
I didn't find anything wrong with the Thank you for that quick fix |
If nobody objects, I'll merge this in a few days. |
Backport to stable-8: 💚 backport PR created✅ Backport PR branch: Backported as #8210 🤖 @patchback |
@sscheib thanks for your contribution! |
* fix: Ensuring interpolation is disabled for ConfigParser This PR disables interpolation of ConfigParser and adds test coverage for that. * Adding changelog fragment * Fixing missing extension of changelog fragment * Adding issue link to changelog fragment * Update changelogs/fragments/8183-from_ini_to_ini.yml Co-authored-by: Felix Fontein <[email protected]> --------- Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit 9307b76)
… disabled for ConfigParser (#8210) fix: Ensuring interpolation is disabled for ConfigParser (#8185) * fix: Ensuring interpolation is disabled for ConfigParser This PR disables interpolation of ConfigParser and adds test coverage for that. * Adding changelog fragment * Fixing missing extension of changelog fragment * Adding issue link to changelog fragment * Update changelogs/fragments/8183-from_ini_to_ini.yml Co-authored-by: Felix Fontein <[email protected]> --------- Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit 9307b76) Co-authored-by: Steffen Scheib <[email protected]>
…lections#8185) * fix: Ensuring interpolation is disabled for ConfigParser This PR disables interpolation of ConfigParser and adds test coverage for that. * Adding changelog fragment * Fixing missing extension of changelog fragment * Adding issue link to changelog fragment * Update changelogs/fragments/8183-from_ini_to_ini.yml Co-authored-by: Felix Fontein <[email protected]> --------- Co-authored-by: Felix Fontein <[email protected]>
SUMMARY
This PR disables interpolation of ConfigParser and adds test coverage for that. Fixes #8183.
ISSUE TYPE
COMPONENT NAME
from_ini
to_ini