Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensuring interpolation is disabled for ConfigParser #8185

Merged
merged 5 commits into from
Apr 9, 2024

Conversation

sscheib
Copy link
Contributor

@sscheib sscheib commented Apr 3, 2024

SUMMARY

This PR disables interpolation of ConfigParser and adds test coverage for that. Fixes #8183.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

from_ini
to_ini

This PR disables interpolation of ConfigParser and adds test coverage for that.
@ansibullbot ansibullbot added bug This issue/PR relates to a bug filter filter plugin integration tests/integration needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR plugins plugin (any type) tests tests labels Apr 3, 2024
@ansibullbot ansibullbot removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Apr 3, 2024
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-8 Automatically create a backport for the stable-8 branch labels Apr 3, 2024
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@Vaarlion
Copy link

Vaarlion commented Apr 4, 2024

I didn't find anything wrong with the from_ini but i think you are right to disable it everywhere :)

Thank you for that quick fix

@felixfontein
Copy link
Collaborator

If nobody objects, I'll merge this in a few days.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Apr 9, 2024
@felixfontein felixfontein merged commit 9307b76 into ansible-collections:main Apr 9, 2024
134 checks passed
Copy link

patchback bot commented Apr 9, 2024

Backport to stable-8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-8/9307b76e744661ef8d62bf829f02393100e8ba91/pr-8185

Backported as #8210

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein
Copy link
Collaborator

@sscheib thanks for your contribution!

patchback bot pushed a commit that referenced this pull request Apr 9, 2024
* fix: Ensuring interpolation is disabled for ConfigParser

This PR disables interpolation of ConfigParser and adds test coverage for that.

* Adding changelog fragment

* Fixing missing extension of changelog fragment

* Adding issue link to changelog fragment

* Update changelogs/fragments/8183-from_ini_to_ini.yml

Co-authored-by: Felix Fontein <[email protected]>

---------

Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit 9307b76)
felixfontein pushed a commit that referenced this pull request Apr 9, 2024
… disabled for ConfigParser (#8210)

fix: Ensuring interpolation is disabled for ConfigParser (#8185)

* fix: Ensuring interpolation is disabled for ConfigParser

This PR disables interpolation of ConfigParser and adds test coverage for that.

* Adding changelog fragment

* Fixing missing extension of changelog fragment

* Adding issue link to changelog fragment

* Update changelogs/fragments/8183-from_ini_to_ini.yml

Co-authored-by: Felix Fontein <[email protected]>

---------

Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit 9307b76)

Co-authored-by: Steffen Scheib <[email protected]>
@sscheib sscheib deleted the fix-interpolation branch April 19, 2024 22:12
Massl123 pushed a commit to Massl123/community.general that referenced this pull request Feb 7, 2025
…lections#8185)

* fix: Ensuring interpolation is disabled for ConfigParser

This PR disables interpolation of ConfigParser and adds test coverage for that.

* Adding changelog fragment

* Fixing missing extension of changelog fragment

* Adding issue link to changelog fragment

* Update changelogs/fragments/8183-from_ini_to_ini.yml

Co-authored-by: Felix Fontein <[email protected]>

---------

Co-authored-by: Felix Fontein <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8 Automatically create a backport for the stable-8 branch bug This issue/PR relates to a bug filter filter plugin integration tests/integration plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

to_ini filter fail to load value with % due to default interpolation option.
4 participants