-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
filesystem: add bcachefs support #8126
filesystem: add bcachefs support #8126
Conversation
f1d23f1
to
8f609b2
Compare
dc02771
to
803d98e
Compare
The UUID checks are most likely failing because the util-linux version on those distros does not have support for bcachefs. I'll try to look at that over the weekend. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! I've added some first comments below.
d1c8c76
to
a5a7607
Compare
Would it be OK to limit the tests to Alpine >= 3.19 for now? That seems to be the only distribution with recent enough versions of both bcachefs-tools and util-linux used in the test matrix. |
I would expect that at least with Arch Linux the tests should also pass, since Arch usually has very up to date packages. (https://archlinux.org/packages/core/x86_64/util-linux/, https://archlinux.org/packages/extra/x86_64/bcachefs-tools/) |
a5a7607
to
5737842
Compare
You're right, looking at the versions I'd expect it to work. I modified the tests to run bcachefs related tasks only on Alpine and Arch Linux. |
50d31f5
to
17d00b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I lost track of this (too many things to do). I'll merge this on the upcoming weekend if nobody objects. There's just one small change needed.
Signed-off-by: Stijn Tintel <[email protected]>
17d00b1
to
a30428d
Compare
486c26b
into
ansible-collections:main
Backport to stable-8: 💚 backport PR created✅ Backport PR branch: Backported as #8251 🤖 @patchback |
Signed-off-by: Stijn Tintel <[email protected]> (cherry picked from commit 486c26b)
@stintel thanks for your contribution! |
…rt (#8251) filesystem: add bcachefs support (#8126) Signed-off-by: Stijn Tintel <[email protected]> (cherry picked from commit 486c26b) Co-authored-by: Stijn Tintel <[email protected]>
Signed-off-by: Stijn Tintel <[email protected]>
Signed-off-by: Stijn Tintel <[email protected]>
SUMMARY
Add support for bcachefs to the filesystem module.
ISSUE TYPE
COMPONENT NAME
filesystem
ADDITIONAL INFORMATION
Test playbook:
Output: