Allow custom providerId in keycloak_user_federation #7789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
module
This comment was marked as outdated.
This comment was marked as outdated.
ansibullbot
added
ci_verified
ansibullbot
removed
ci_verified
changelogs/fragments/7789-keycloak-user-federation-custom-provider-type.yml
Outdated
Show resolved
Hide resolved
felixfontein
added
check-before-release
Co-authored-by: Felix Fontein <[email protected]>
|
Looks good to me! If nobody objects, I'll merge this in a few days. |
felixfontein
removed
the
check-before-release
Backport to stable-8: 💚 backport PR created✅ Backport PR branch: Backported as #7804 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Dec 31, 2023
* Update keycloak_user_federation.py * stub out changelog * update PR reference * remove 'choices' from documentation * Apply suggestions from code review Co-authored-by: Felix Fontein <[email protected]> --------- Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit 08ece2e)
|
@clifff thanks for your contribution! |
felixfontein
pushed a commit
that referenced
this pull request
Dec 31, 2023
…cloak_user_federation (#7804) Allow custom providerId in keycloak_user_federation (#7789) * Update keycloak_user_federation.py * stub out changelog * update PR reference * remove 'choices' from documentation * Apply suggestions from code review Co-authored-by: Felix Fontein <[email protected]> --------- Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit 08ece2e) Co-authored-by: Clif Reeder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Removes the restriction from the
keycloak_user_federationmodule thatproviderIdcan only beldap,kerberos, orsssd.ISSUE TYPE
COMPONENT NAME
keycloak_user_federationADDITIONAL INFORMATION
Restricting the options for this fields prevents being able to manage custom federation adapters.