Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipa: ipa_pwpolicy update pwpolicy module #7723

Merged
merged 3 commits into from
Dec 31, 2023
Merged

ipa: ipa_pwpolicy update pwpolicy module #7723

merged 3 commits into from
Dec 31, 2023

Conversation

parsa97
Copy link
Contributor

@parsa97 parsa97 commented Dec 14, 2023 •
edited
Loading

SUMMARY

Freeipa 4 add support more options in password policies maxrepeat, maxsequence, dictcheck, usercheck, gracelimit

With this feature we can set these options for our password policies.

ISSUE TYPE
  • Feature Pull Request
  • Refactoring
COMPONENT NAME

ipa_pwpolicy

ADDITIONAL INFORMATION

link to freeipa document about pwpolicy options

@ansibullbot
Copy link
Collaborator

cc @Akasurde @Nosmoht @adralioh @fxfitz @justchris1
click here for bot help

@ansibullbot ansibullbot added feature This issue/PR relates to a feature request module module new_contributor Help guide this first time contributor plugins plugin (any type) tests tests unit tests/unit needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Dec 14, 2023
@parsa97 parsa97 force-pushed the ipa-pwpolicy-passwordgracelimit branch from 6f18f12 to 77ad97b Compare December 14, 2023 14:35
@ansibullbot ansibullbot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label Dec 14, 2023
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-8 Automatically create a backport for the stable-8 branch labels Dec 14, 2023
felixfontein
felixfontein reviewed Dec 14, 2023
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Please add a changelog fragment. Thanks.

@parsa97 parsa97 force-pushed the ipa-pwpolicy-passwordgracelimit branch 2 times, most recently from cc321f8 to 3591dba Compare December 14, 2023 20:59
@ansibullbot

This comment was marked as outdated.

Sign in to view
@ansibullbot ansibullbot added ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Dec 14, 2023
@parsa97 parsa97 force-pushed the ipa-pwpolicy-passwordgracelimit branch from 3591dba to 49fbd0f Compare December 14, 2023 21:16
@ansibullbot ansibullbot removed ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Dec 14, 2023
@parsa97 parsa97 changed the title ipa: ipa_pwpolicy add passwordgracelimit option ipa: ipa_pwpolicy update pwpolicy module Dec 14, 2023
@parsa97 parsa97 force-pushed the ipa-pwpolicy-passwordgracelimit branch from d7c6926 to b922d40 Compare December 14, 2023 21:48
@parsa97 parsa97 force-pushed the ipa-pwpolicy-passwordgracelimit branch from b922d40 to 65917b1 Compare December 15, 2023 08:01
@ansibullbot ansibullbot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label Dec 15, 2023
@parsa97 parsa97 force-pushed the ipa-pwpolicy-passwordgracelimit branch from 65917b1 to f3ec907 Compare December 15, 2023 08:47
@ansibullbot ansibullbot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label Dec 15, 2023
@parsa97 parsa97 force-pushed the ipa-pwpolicy-passwordgracelimit branch from 8740255 to 021e7fa Compare December 18, 2023 08:24
@ansibullbot

This comment was marked as outdated.

Sign in to view
@ansibullbot ansibullbot added merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels Dec 24, 2023
@parsa97 parsa97 force-pushed the ipa-pwpolicy-passwordgracelimit branch from a9afe4d to a031bec Compare December 24, 2023 09:55
@ansibullbot ansibullbot removed merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels Dec 24, 2023
@parsa97 parsa97 force-pushed the ipa-pwpolicy-passwordgracelimit branch from a031bec to 3754245 Compare December 24, 2023 10:45
felixfontein
felixfontein reviewed Dec 24, 2023
View reviewed changes
@parsa97 parsa97 force-pushed the ipa-pwpolicy-passwordgracelimit branch 2 times, most recently from 59dfc2d to 48d4960 Compare December 27, 2023 17:54
felixfontein
felixfontein reviewed Dec 27, 2023
View reviewed changes
@parsa97 parsa97 force-pushed the ipa-pwpolicy-passwordgracelimit branch from 48d4960 to adec4bd Compare December 27, 2023 20:15
felixfontein
felixfontein approved these changes Dec 28, 2023
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. If nobody objects, I'll merge this in a few days.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Dec 31, 2023
@felixfontein felixfontein merged commit 6afe35d into ansible-collections:main Dec 31, 2023
121 checks passed
@patchback Patchback
Copy link

patchback bot commented Dec 31, 2023 •
edited
Loading

Backport to stable-8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-8/6afe35d26345eb2cb3a232c0ee935bee7cc6b009/pr-7723

Backported as #7801

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Dec 31, 2023
@parsa97 @patchback
ipa: ipa_pwpolicy update pwpolicy module (#7723)
375e1f3 
* ipa: ipa_pwpolicy support maxrepeat, maxsequence, dictcheck, usercheck, gracelimit

* ipa: ipa_pwdpolicy replace if statements with for loop

* ipa: ipa_pwdpolicy add changelog

(cherry picked from commit 6afe35d)
@patchback patchback bot mentioned this pull request Dec 31, 2023
Merged
@felixfontein
Copy link
Collaborator

@parsa97 thanks for your contribution!
@justchris1 thanks for reviewing!

felixfontein pushed a commit that referenced this pull request Dec 31, 2023
@patchback @parsa97
[PR #7723/6afe35d2 backport][stable-8] ipa: ipa_pwpolicy update pwpol…
4776e7b 
…icy module (#7801)

ipa: ipa_pwpolicy update pwpolicy module (#7723)

* ipa: ipa_pwpolicy support maxrepeat, maxsequence, dictcheck, usercheck, gracelimit

* ipa: ipa_pwdpolicy replace if statements with for loop

* ipa: ipa_pwdpolicy add changelog

(cherry picked from commit 6afe35d)

Co-authored-by: Parsa Yousefi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justchris1 justchris1 justchris1 left review comments

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
backport-8 Automatically create a backport for the stable-8 branch feature This issue/PR relates to a feature request module module new_contributor Help guide this first time contributor plugins plugin (any type) tests tests unit tests/unit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@parsa97 @ansibullbot @felixfontein @justchris1