Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

interfaces_file: filter by address_familiy when updating method #7612

Merged
merged 2 commits into from
Nov 26, 2023
Merged

interfaces_file: filter by address_familiy when updating method #7612

merged 2 commits into from
Nov 26, 2023

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

Fixes #7610.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

interfaces_file

@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-7 backport-8 Automatically create a backport for the stable-8 branch labels Nov 26, 2023
@felixfontein felixfontein mentioned this pull request Nov 26, 2023
Closed
1 task
hryamzik
hryamzik approved these changes Nov 26, 2023
View reviewed changes
Copy link
Contributor

@hryamzik hryamzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as soon as it passes tests. Thanks!

@ansibullbot
Copy link
Collaborator

cc @hryamzik @obourdon
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug has_issue integration tests/integration module module plugins plugin (any type) shipit tests tests labels Nov 26, 2023
@felixfontein felixfontein merged commit 5adb7ab into ansible-collections:main Nov 26, 2023
@patchback Patchback
Copy link

patchback bot commented Nov 26, 2023 •
edited
Loading

Backport to stable-7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-7/5adb7ab948d79fba6f7c7a335b6fce3865813270/pr-7612

Backported as #7615

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein felixfontein deleted the interfaces_file branch November 26, 2023 18:34
patchback bot pushed a commit that referenced this pull request Nov 26, 2023
@felixfontein @patchback
interfaces_file: filter by address_familiy when updating method (#7612)
a470e2c 
* When updating method, check address_family if provided.

* Also test modifying 'method' without address_family filter.

(cherry picked from commit 5adb7ab)
@patchback patchback bot mentioned this pull request Nov 26, 2023
Merged
@patchback Patchback
Copy link

patchback bot commented Nov 26, 2023 •
edited
Loading

Backport to stable-8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-8/5adb7ab948d79fba6f7c7a335b6fce3865813270/pr-7612

Backported as #7616

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein
Copy link
Collaborator Author

@hryamzik thanks a lot for reviewing this one as well!

patchback bot pushed a commit that referenced this pull request Nov 26, 2023
@felixfontein @patchback
interfaces_file: filter by address_familiy when updating method (#7612)
df54dde 
* When updating method, check address_family if provided.

* Also test modifying 'method' without address_family filter.

(cherry picked from commit 5adb7ab)
@patchback patchback bot mentioned this pull request Nov 26, 2023
Merged
felixfontein added a commit that referenced this pull request Nov 26, 2023
@patchback @felixfontein
[PR #7612/5adb7ab9 backport][stable-7] interfaces_file: filter by add…
d789351 
…ress_familiy when updating method (#7615)

interfaces_file: filter by address_familiy when updating method (#7612)

* When updating method, check address_family if provided.

* Also test modifying 'method' without address_family filter.

(cherry picked from commit 5adb7ab)

Co-authored-by: Felix Fontein <[email protected]>
felixfontein added a commit that referenced this pull request Nov 26, 2023
@patchback @felixfontein
[PR #7612/5adb7ab9 backport][stable-8] interfaces_file: filter by add…
e3eaeda 
…ress_familiy when updating method (#7616)

interfaces_file: filter by address_familiy when updating method (#7612)

* When updating method, check address_family if provided.

* Also test modifying 'method' without address_family filter.

(cherry picked from commit 5adb7ab)

Co-authored-by: Felix Fontein <[email protected]>
samdoran pushed a commit to samdoran/community.general that referenced this pull request Nov 26, 2023
@felixfontein @samdoran
interfaces_file: filter by address_familiy when updating method (ansi…
e667616 
…ble-collections#7612)

* When updating method, check address_family if provided.

* Also test modifying 'method' without address_family filter.
@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hryamzik hryamzik hryamzik approved these changes

Assignees
No one assigned
Labels
backport-8 Automatically create a backport for the stable-8 branch bug This issue/PR relates to a bug has_issue integration tests/integration module module plugins plugin (any type) shipit tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Updating network interface method ignores specified address family
3 participants
@felixfontein @ansibullbot @hryamzik