-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redfish: Updated message handling for update operations to skip message objects with missing MessageId properties #7471
Redfish: Updated message handling for update operations to skip message objects with missing MessageId properties #7471
Conversation
…ge objects with missing MessageId properties Signed-off-by: Mike Raineri <[email protected]>
recheck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I'll merge this beginning of the upcoming week if nobody objects.
Backport to stable-7: 💚 backport PR created✅ Backport PR branch: Backported as #7491 🤖 @patchback |
…ge objects with missing MessageId properties (#7471) * Redfish: Updated message handling for update operations to skip message objects with missing MessageId properties Signed-off-by: Mike Raineri <[email protected]> * Update 7465-redfish-firmware-update-message-id-hardening.yml --------- Signed-off-by: Mike Raineri <[email protected]> (cherry picked from commit ab0b85d)
Backport to stable-8: 💚 backport PR created✅ Backport PR branch: Backported as #7492 🤖 @patchback |
@mraineri thanks a lot for this fix! |
…ge objects with missing MessageId properties (#7471) * Redfish: Updated message handling for update operations to skip message objects with missing MessageId properties Signed-off-by: Mike Raineri <[email protected]> * Update 7465-redfish-firmware-update-message-id-hardening.yml --------- Signed-off-by: Mike Raineri <[email protected]> (cherry picked from commit ab0b85d)
…ing for update operations to skip message objects with missing MessageId properties (#7491) Redfish: Updated message handling for update operations to skip message objects with missing MessageId properties (#7471) * Redfish: Updated message handling for update operations to skip message objects with missing MessageId properties Signed-off-by: Mike Raineri <[email protected]> * Update 7465-redfish-firmware-update-message-id-hardening.yml --------- Signed-off-by: Mike Raineri <[email protected]> (cherry picked from commit ab0b85d) Co-authored-by: Mike Raineri <[email protected]>
…ing for update operations to skip message objects with missing MessageId properties (#7492) Redfish: Updated message handling for update operations to skip message objects with missing MessageId properties (#7471) * Redfish: Updated message handling for update operations to skip message objects with missing MessageId properties Signed-off-by: Mike Raineri <[email protected]> * Update 7465-redfish-firmware-update-message-id-hardening.yml --------- Signed-off-by: Mike Raineri <[email protected]> (cherry picked from commit ab0b85d) Co-authored-by: Mike Raineri <[email protected]>
SUMMARY
Updated message handling for update operations to skip message objects with missing MessageId properties. While this is invalid, it's easy to handle and just move on to other messages to surface to the user.
Fix #7465
ISSUE TYPE
COMPONENT NAME
redfish_utils, redfish_command
ADDITIONAL INFORMATION
Output after change.