Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nomad_job port parameter #7412

Merged

Conversation

apecnascimento
Copy link
Contributor

@apecnascimento apecnascimento commented Oct 20, 2023

SUMMARY

Add port parameter to connect to nomad server

Fixes #7411

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

nomad_job

@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added feature This issue/PR relates to a feature request module module new_contributor Help guide this first time contributor plugins plugin (any type) labels Oct 20, 2023
@ansibullbot ansibullbot added the docs_fragments docs_fragments plugin (shared docs) label Oct 20, 2023
@ansibullbot

This comment was marked as outdated.

@ansibullbot ansibullbot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label Oct 20, 2023
@ansibullbot ansibullbot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label Oct 20, 2023
@felixfontein felixfontein added the check-before-release PR will be looked at again shortly before release and merged if possible. label Oct 20, 2023
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@ansibullbot ansibullbot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label Oct 20, 2023
@apecnascimento
Copy link
Contributor Author

/rebuild

@ansibullbot ansibullbot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label Oct 20, 2023
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! If nobody objects, I'll merge this by mid of next week.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Oct 25, 2023
@felixfontein felixfontein merged commit 714e060 into ansible-collections:main Oct 25, 2023
@felixfontein
Copy link
Collaborator

@apecnascimento thanks for your contribution!

etrombly pushed a commit to etrombly/community.general that referenced this pull request Oct 25, 2023
* Add nomad_job port parameter

* Add changelog frag

* Update doc frag

* Fix trailing whitespace

* Add port to nomad_info

* Update changelogs/fragments/7412-add-port-for-nomad-connection.yaml

Co-authored-by: Felix Fontein <[email protected]>

* Update plugins/doc_fragments/nomad.py

Co-authored-by: Felix Fontein <[email protected]>

* Add space

* Remove trailing whitespace

---------

Co-authored-by: Felix Fontein <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs_fragments docs_fragments plugin (shared docs) feature This issue/PR relates to a feature request module module new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nomad_job module needs support host ports difent than 4646
3 participants