Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #7355/85e866cc backport][stable-7] newrelic_deployment: add app_name_exact_match parameter #7367

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Oct 8, 2023

This is a backport of PR #7355 as merged into main (85e866c).

SUMMARY

Adds the optional app_name_exact_match flag to the newrelic_deployment module.
This flag ensures that the exact app id is obtained from the newrelic api and not the first result if there is also a parcial match.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

newrelic_deployment

ADDITIONAL INFORMATION

In my opinion this should be the default behavior but I set it as optional so that it doesn't break anyone's usage.

* newrelic_deployment: add app_name_exact_match parameter

* add changelog

* fix ident

* fix line ending format

* Update plugins/modules/newrelic_deployment.py

Co-authored-by: Felix Fontein <[email protected]>

* Update changelogs/fragments/7355-newrelic-deployment-add-exact-name.yml

Co-authored-by: Felix Fontein <[email protected]>

* Update plugins/modules/newrelic_deployment.py

Co-authored-by: Felix Fontein <[email protected]>

* Update plugins/modules/newrelic_deployment.py

Co-authored-by: Felix Fontein <[email protected]>

* Update plugins/modules/newrelic_deployment.py

Co-authored-by: Felix Fontein <[email protected]>

* Update plugins/modules/newrelic_deployment.py

Co-authored-by: Felix Fontein <[email protected]>

* Write out abbreviation.

---------

Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit 85e866c)
@ansibullbot ansibullbot added backport feature This issue/PR relates to a feature request module module needs_maintainer needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR new_contributor Help guide this first time contributor plugins plugin (any type) and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Oct 8, 2023
@felixfontein felixfontein merged commit c1309ce into stable-7 Oct 8, 2023
@felixfontein felixfontein deleted the patchback/backports/stable-7/85e866ccdd6cdbd30377f57acc2235b5aca8c711/pr-7355 branch October 8, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This issue/PR relates to a feature request module module needs_maintainer new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants