Improvements to the jenkins_build module and new jenkins_build_info module #7204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
feature
|
The test |
Doesn't really make sense to test that with a mock
|
I don't really know why |
ansibullbot
added
ci_verified
|
You added yourself to the authors list, but not to the maintainers list: the maintainer list for jenkins_build is here: https://github.com/ansible-collections/community.general/blob/main/.github/BOTMETA.yml#L672. You need to add new entries for the new modules there as well (also see https://github.com/ansible-collections/community.general/blob/main/CONTRIBUTING.md#creating-new-modules-or-plugins). |
felixfontein
added
check-before-release
|
Done, sorry I missed that @felixfontein. Let me know if you need something else from me to merge this! |
ansibullbot
removed
the
needs_revision
felixfontein
reviewed
Sep 7, 2023
felixfontein
approved these changes
Sep 8, 2023
felixfontein
removed
the
check-before-release
Backport to stable-7: 💚 backport PR created✅ Backport PR branch: Backported as #7234 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Sep 10, 2023
…odule (#7204) * Add detach option so the task doesn't wait until the Jenkins job is finished * Add new time_between_checks to be able to configure the sleep time between requests * New jenkins_build_info to get information about a specific build * Add version_added to the new module * Add changelog fragment for jenkins_build changes * Fix tests that required the python-jenkins module * Remove tests that failed Doesn't really make sense to test that with a mock * Fix pep8 error * Update maintainers for the jenkins_build and jenkins_build_info modules * Improve format and add link to PR * Move version_added documentation to the right file * Fix incorrect examples * Improve text format * Fix incorrect code style * Fix incorrect YAML for documentation * Add version_added documentation to the new options (cherry picked from commit afeeb89)
|
@juanmcasanova thanks for your contribution! |
felixfontein
pushed a commit
that referenced
this pull request
Sep 11, 2023
…ild module and new jenkins_build_info module (#7234) Improvements to the jenkins_build module and new jenkins_build_info module (#7204) * Add detach option so the task doesn't wait until the Jenkins job is finished * Add new time_between_checks to be able to configure the sleep time between requests * New jenkins_build_info to get information about a specific build * Add version_added to the new module * Add changelog fragment for jenkins_build changes * Fix tests that required the python-jenkins module * Remove tests that failed Doesn't really make sense to test that with a mock * Fix pep8 error * Update maintainers for the jenkins_build and jenkins_build_info modules * Improve format and add link to PR * Move version_added documentation to the right file * Fix incorrect examples * Improve text format * Fix incorrect code style * Fix incorrect YAML for documentation * Add version_added documentation to the new options (cherry picked from commit afeeb89) Co-authored-by: Juan Manuel Casanova González <[email protected]>
etrombly
pushed a commit
to etrombly/community.general
that referenced
this pull request
Oct 25, 2023
…odule (ansible-collections#7204) * Add detach option so the task doesn't wait until the Jenkins job is finished * Add new time_between_checks to be able to configure the sleep time between requests * New jenkins_build_info to get information about a specific build * Add version_added to the new module * Add changelog fragment for jenkins_build changes * Fix tests that required the python-jenkins module * Remove tests that failed Doesn't really make sense to test that with a mock * Fix pep8 error * Update maintainers for the jenkins_build and jenkins_build_info modules * Improve format and add link to PR * Move version_added documentation to the right file * Fix incorrect examples * Improve text format * Fix incorrect code style * Fix incorrect YAML for documentation * Add version_added documentation to the new options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Note: This PR actually includes three separate changes, if you prefer to have them in separate PRs just ask!
Due to some special requirements on our part, we needed (and added) the following:
Tested with Jenkins 2.235.5 and 2.401.3.
ISSUE TYPE
COMPONENT NAME
jenkins_build and jenkins_build_info
ADDITIONAL INFORMATION
For a bit of context, we are dealing with an external Jenkins server that randomly fails. This means that due to how the jenkins_build module works we were getting random errors on our Ansible playbook (although the Jenkins build would actually continue).
With these changes we are able to craft a playbook that, even if the server returns an error sometimes, is able to retry and actually check if the build kept going.