nmap inventory plugin, add use_arp_ping option #7119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
bug
1 task
Co-authored-by: Felix Fontein <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
felixfontein
added
check-before-release
|
If nobody objects I'll merge this weekend. |
felixfontein
removed
the
check-before-release
Backport to stable-7: 💚 backport PR created✅ Backport PR branch: Backported as #7134 🤖 @patchback |
|
@bcoca thanks! |
patchback bot
pushed a commit
that referenced
this pull request
Aug 20, 2023
* nmap inventory plugin, add use_arp_ping option * Apply suggestions from code review Co-authored-by: Felix Fontein <[email protected]> * Update plugins/inventory/nmap.py Co-authored-by: Felix Fontein <[email protected]> --------- Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit eaf3926)
felixfontein
pushed a commit
that referenced
this pull request
Aug 20, 2023
…_arp_ping option (#7134) nmap inventory plugin, add use_arp_ping option (#7119) * nmap inventory plugin, add use_arp_ping option * Apply suggestions from code review Co-authored-by: Felix Fontein <[email protected]> * Update plugins/inventory/nmap.py Co-authored-by: Felix Fontein <[email protected]> --------- Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit eaf3926) Co-authored-by: Brian Coca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also ensured all options correctly use
get_option.fixes #7118
ISSUE TYPE
COMPONENT NAME
plugins/inventory/nmap