[PR #7053/a0c67a88 backport][stable-7] lvol: Fix pct of origin #7097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
* add support for percentage of origin size for creating snapshot volumes * add changelog fragment * add pull request link Co-authored-by: Felix Fontein <[email protected]> * fix what's not idempotent --------- Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit a0c67a8)
ansibullbot
added
backport
bug
felixfontein
deleted the
patchback/backports/stable-7/a0c67a88949fa7ca204740d84bfc37e950b0f3b3/pr-7053
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #7053 as merged into main (a0c67a8).
SUMMARY
The
sizeparameter of thelvolmodule did not support percentage of origin size specification when creating a snapshot volume. This is valid according to lvcreate(8). This PR addresses the issue.I increased the size of the loop devices in the test playbook to accommodate creating test snapshot LVs. The modified tests worked for me locally. Fingers crossed for the CI workflow.
Fixes #1630
ISSUE TYPE
COMPONENT NAME
lvolmoduleADDITIONAL INFORMATION
My first PR to the community.general collection. Kindly guide me if I've done anything wrong. Thanks!