-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix KeycloakAPI's missing http_agent, timeout, and validate_certs open_url() parameters #7067
Conversation
…n_url() parameters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
I think this really needs to be refactored so that all the common parameters are passed in one place, instead of having them repeated again in every place... But that's something for another PR, not for this one!
Following suggestion Co-authored-by: Felix Fontein <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will merge this by the end of this week if nobody objects.
Backport to stable-6: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply e7a6412 on top of patchback/backports/stable-6/e7a6412ec471d74e59ffb6e8dc1481805ebebfab/pr-7067 Backporting merged PR #7067 into main
🤖 @patchback |
Backport to stable-7: 💚 backport PR created✅ Backport PR branch: Backported as #7088 🤖 @patchback |
…n_url() parameters (#7067) * Fix KeycloakAPI's missing http_agent, timeout, and validate_certs open_url() parameters * Add changelog fragment * Update changelogs/fragments/7067-keycloak-api-paramerter-fix.yml Following suggestion Co-authored-by: Felix Fontein <[email protected]> --------- Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit e7a6412)
@loricvdt thanks for your contribution |
…_agent, timeout, and validate_certs open_url() parameters (#7088) Fix KeycloakAPI's missing http_agent, timeout, and validate_certs open_url() parameters (#7067) * Fix KeycloakAPI's missing http_agent, timeout, and validate_certs open_url() parameters * Add changelog fragment * Update changelogs/fragments/7067-keycloak-api-paramerter-fix.yml Following suggestion Co-authored-by: Felix Fontein <[email protected]> --------- Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit e7a6412) Co-authored-by: Loric Vandentempel <[email protected]>
SUMMARY
Added
http_agent
,timeout
, andvalidate_certs
toopen_url()
calls where they were missing in the KeycloakAPI module utilISSUE TYPE
COMPONENT NAME
keycloak
API module utilADDITIONAL INFORMATION
Copied the same argument structure as all other
open_url()
calls in the same Python file.An example issue was using
community.general.keycloak_user
to create a user, which would complain about SSL verification eventhoughvalidate_certs
was set tofalse