snap: add param "dangerous" #6908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
docs
integration
felixfontein
added
check-before-release
|
recheck |
felixfontein
removed
the
check-before-release
Backport to stable-7: 💚 backport PR created✅ Backport PR branch: Backported as #6944 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jul 15, 2023
* snap: add param "dangerous" * adjusted run_command out for simple test case * add changelog frag (cherry picked from commit ea6fb9d)
|
@russoz thanks! |
felixfontein
pushed a commit
that referenced
this pull request
Jul 15, 2023
…6944) snap: add param "dangerous" (#6908) * snap: add param "dangerous" * adjusted run_command out for simple test case * add changelog frag (cherry picked from commit ea6fb9d) Co-authored-by: Alexei Znamensky <[email protected]>
valeriopoggi
pushed a commit
to valeriopoggi/community.general
that referenced
this pull request
Jul 17, 2023
* snap: add param "dangerous" * adjusted run_command out for simple test case * add changelog frag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Add
dangerousparameter to module, mapping to CLI parameter--dangerous.Because of explicitly considering named snap files in the
nameparameter, more logic was required to ensure the idempotency of the module.Fixes #5715
ISSUE TYPE
COMPONENT NAME
snap