Added support in nmcli for ipv4.dns-options #6902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Felix Fontein <[email protected]>
…-support-in-nmcli-for-ipvx-dns-options.yml
…options.yml Co-authored-by: Felix Fontein <[email protected]>
ansibullbot
added
feature
felixfontein
added
check-before-release
felixfontein
approved these changes
Jul 9, 2023
felixfontein
removed
the
check-before-release
Backport to stable-7: 💚 backport PR created✅ Backport PR branch: Backported as #6926 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jul 13, 2023
* Added support for ipv4.dns_options in nmcli module * added support for dns6-options * Added version added Co-authored-by: Felix Fontein <[email protected]> * added version_added: 4.6.0 for dns6 options * added changelog fragment * Rename 4308-added-support-in-nmcli-for-ipvx-dns-options to 4308-added-support-in-nmcli-for-ipvx-dns-options.yml * Update changelogs/fragments/4308-added-support-in-nmcli-for-ipvx-dns-options.yml Co-authored-by: Felix Fontein <[email protected]> * Fix and add tests * Update PR number and version_added --------- Co-authored-by: Matteo Caruso <[email protected]> Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit cc8e2d6)
felixfontein
pushed a commit
that referenced
this pull request
Jul 13, 2023
…4.dns-options (#6926) Added support in nmcli for ipv4.dns-options (#6902) * Added support for ipv4.dns_options in nmcli module * added support for dns6-options * Added version added Co-authored-by: Felix Fontein <[email protected]> * added version_added: 4.6.0 for dns6 options * added changelog fragment * Rename 4308-added-support-in-nmcli-for-ipvx-dns-options to 4308-added-support-in-nmcli-for-ipvx-dns-options.yml * Update changelogs/fragments/4308-added-support-in-nmcli-for-ipvx-dns-options.yml Co-authored-by: Felix Fontein <[email protected]> * Fix and add tests * Update PR number and version_added --------- Co-authored-by: Matteo Caruso <[email protected]> Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit cc8e2d6) Co-authored-by: Chih-Hsuan Yen <[email protected]>
valeriopoggi
pushed a commit
to valeriopoggi/community.general
that referenced
this pull request
Jul 17, 2023
* Added support for ipv4.dns_options in nmcli module * added support for dns6-options * Added version added Co-authored-by: Felix Fontein <[email protected]> * added version_added: 4.6.0 for dns6 options * added changelog fragment * Rename 4308-added-support-in-nmcli-for-ipvx-dns-options to 4308-added-support-in-nmcli-for-ipvx-dns-options.yml * Update changelogs/fragments/4308-added-support-in-nmcli-for-ipvx-dns-options.yml Co-authored-by: Felix Fontein <[email protected]> * Fix and add tests * Update PR number and version_added --------- Co-authored-by: Matteo Caruso <[email protected]> Co-authored-by: Felix Fontein <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The nmcli command has an important option "ipv4.dns-options", This PR adds the support for this option in the nmcli module
Closes #4308
ISSUE TYPE
COMPONENT NAME
nmcli
ADDITIONAL INFORMATION
This a rebased and improved version of #4308.