Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #6734/77480026 backport][stable-7] Fix Keycloak authentication management indexing #6894

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Jul 8, 2023

This is a backport of PR #6734 as merged into main (7748002).

SUMMARY

This PR fixes an issue with indexation during the update of an authentication flow, more specifically a step (execution or sub-flow). The older behavior caused the to-be-updated step to change its index, even though the user didn't specify it.

Next (even though this is a refac), the provider ID according to Keycloak can only be basic-flow or client-flow. So I introduced choices for it.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

keycloak_authentication

* fix: keep original index

* refac: provider id choice

* refac: default

* fix: missing docs

* fix: ident

* fix: yaml formatting

* chore: bugfix changelog fragment

* fix: remove minor changes form current PR

* fix: missing yml extension

* Update changelogs/fragments/6734-keycloak-auth-management-indexing.yml

Co-authored-by: Felix Fontein <[email protected]>

---------

Co-authored-by: Skrekulko <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit 7748002)
@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added backport bug This issue/PR relates to a bug module module needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR new_contributor Help guide this first time contributor plugins plugin (any type) and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Jul 8, 2023
@felixfontein felixfontein merged commit ebaf490 into stable-7 Jul 8, 2023
@felixfontein felixfontein deleted the patchback/backports/stable-7/7748002636bd7c68d384e92bd11d0c5fe744717c/pr-6734 branch July 8, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug module module new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants