Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] proxmox module utils: pass timeout parameter to ProxmoxAPI #6872

Closed

Conversation

russoz
Copy link
Collaborator

@russoz russoz commented Jul 6, 2023

SUMMARY

For the proxmox* modules that have a timeout parameter, pass its value to the underlying ProxmoxAPI object.

Fixes #6843

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

plugins/module_utils/proxmox.py

@ansibullbot ansibullbot added feature This issue/PR relates to a feature request module_utils module_utils plugins plugin (any type) labels Jul 6, 2023
@UnderGreen
Copy link
Contributor

How proxmoxer/Proxmox would handle modules, where timeout param is set(but timeout there is implemented programmatically in module itself), but API doesn't allow that parameter?

@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-7 labels Jul 7, 2023
@felixfontein
Copy link
Collaborator

Also this needs a changelog fragment :)

@russoz russoz changed the title proxmox module utils: pass timeout parameter to ProxmoxAPI [WIP] proxmox module utils: pass timeout parameter to ProxmoxAPI Jul 7, 2023
@russoz
Copy link
Collaborator Author

russoz commented Jul 7, 2023

How proxmoxer/Proxmox would handle modules, where timeout param is set(but timeout there is implemented programmatically in module itself), but API doesn't allow that parameter?

Not sure if I follow that last part "but API doesn't allow that parameter".

But reading the code again, I am having second thoughts about the way I implemented that. I had simply passed the timeout to the underlying httplib, but with that we missing the ability of polling the API.

Will need to rethink this.

@ansibullbot ansibullbot added the WIP Work in progress label Jul 7, 2023
@ansibullbot ansibullbot added the stale_ci CI is older than 7 days, rerun before merging label Jul 15, 2023
@felixfontein felixfontein added the backport-8 Automatically create a backport for the stable-8 branch label Nov 1, 2023
@felixfontein
Copy link
Collaborator

CC @krauthosting

@russoz
Copy link
Collaborator Author

russoz commented Apr 16, 2024

Hi folks, I don't think I will have time to look into that issue anytime soon. Sorry.

@russoz russoz closed this Apr 16, 2024
@russoz russoz deleted the proxmox-timeout branch April 16, 2024 10:25
@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8 Automatically create a backport for the stable-8 branch feature This issue/PR relates to a feature request module_utils module_utils plugins plugin (any type) stale_ci CI is older than 7 days, rerun before merging WIP Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proxmox LXC Create Container runs into timeout
4 participants