Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proxmox module utils: better error msg when token fails with old proxmoxer #6839

Merged
merged 3 commits into from
Jul 3, 2023
Merged

proxmox module utils: better error msg when token fails with old proxmoxer #6839

merged 3 commits into from
Jul 3, 2023

Conversation

russoz
Copy link
Collaborator

@russoz russoz commented Jul 3, 2023

SUMMARY

Add logic to detect whether an old Promoxer complains about the token_name and token_value parameters and provide a better error message when that happens.

Fixes #5371

ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
COMPONENT NAME

plugins/module_utils/proxmox.py

@ansibullbot ansibullbot added bug This issue/PR relates to a bug docs_fragments docs_fragments plugin (shared docs) module_utils module_utils needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR plugins plugin (any type) and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Jul 3, 2023
@russoz russoz changed the title proxmox module utils: clear msg when token fails with old proxmoxer proxmox module utils: better error msg when token fails with old proxmoxer Jul 3, 2023
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-6 labels Jul 3, 2023
@felixfontein
Copy link
Collaborator

CC @UnderGreen

@felixfontein felixfontein merged commit e5dc697 into ansible-collections:main Jul 3, 2023
@patchback
Copy link

patchback bot commented Jul 3, 2023 •
edited
Loading

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/e5dc69788799168c0f53c1da636262c81d8fdc5b/pr-6839

Backported as #6845

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Jul 3, 2023
@felixfontein
Copy link
Collaborator

@russoz @UnderGreen thanks a lot!

patchback bot pushed a commit that referenced this pull request Jul 3, 2023
@russoz @patchback
proxmox module utils: better error msg when token fails with old prox…
dd29f78 
…moxer (#6839)

* proxmox module utils: clear msg when token fails with old proxmoxer

* add changelog frag

* better way to determine version

(cherry picked from commit e5dc697)
@patchback patchback bot mentioned this pull request Jul 3, 2023
Merged
@patchback
Copy link

patchback bot commented Jul 3, 2023 •
edited
Loading

Backport to stable-7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-7/e5dc69788799168c0f53c1da636262c81d8fdc5b/pr-6839

Backported as #6846

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jul 3, 2023
@russoz @patchback
proxmox module utils: better error msg when token fails with old prox…
a96a809 
…moxer (#6839)

* proxmox module utils: clear msg when token fails with old proxmoxer

* add changelog frag

* better way to determine version

(cherry picked from commit e5dc697)
@patchback patchback bot mentioned this pull request Jul 3, 2023
Merged
@russoz russoz deleted the 5371-no-token-for-old-proxmoxer branch July 3, 2023 20:12
felixfontein pushed a commit that referenced this pull request Jul 3, 2023
@patchback @russoz
[PR #6839/e5dc6978 backport][stable-6] proxmox module utils: better e…
d633f6c 
…rror msg when token fails with old proxmoxer (#6845)

proxmox module utils: better error msg when token fails with old proxmoxer (#6839)

* proxmox module utils: clear msg when token fails with old proxmoxer

* add changelog frag

* better way to determine version

(cherry picked from commit e5dc697)

Co-authored-by: Alexei Znamensky <[email protected]>
felixfontein pushed a commit that referenced this pull request Jul 3, 2023
@patchback @russoz
[PR #6839/e5dc6978 backport][stable-7] proxmox module utils: better e…
3ee01dd 
…rror msg when token fails with old proxmoxer (#6846)

proxmox module utils: better error msg when token fails with old proxmoxer (#6839)

* proxmox module utils: clear msg when token fails with old proxmoxer

* add changelog frag

* better way to determine version

(cherry picked from commit e5dc697)

Co-authored-by: Alexei Znamensky <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UnderGreen UnderGreen UnderGreen approved these changes

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug docs_fragments docs_fragments plugin (shared docs) module_utils module_utils plugins plugin (any type)
Projects
None yet
Milestone
No milestone
4 participants
@russoz @felixfontein @UnderGreen @ansibullbot