-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
locale_gen: refactor module to use CmdRunner #6820
Merged
felixfontein
merged 2 commits into
ansible-collections:main
from
russoz-ansible:locale-gen-cmdrunner
Jul 6, 2023
Merged
locale_gen: refactor module to use CmdRunner #6820
felixfontein
merged 2 commits into
ansible-collections:main
from
russoz-ansible:locale-gen-cmdrunner
Jul 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Also this needs a changelog fragment :) ) |
yup, I am waiting for the CI to run, to make sure we're good |
felixfontein
approved these changes
Jul 2, 2023
Backport to stable-7: 💚 backport PR created✅ Backport PR branch: Backported as #6867 🤖 @patchback |
@russoz thanks! |
patchback bot
pushed a commit
that referenced
this pull request
Jul 6, 2023
* refactor module to use CmdRunner * add changelog frag (cherry picked from commit 601fa0d)
felixfontein
pushed a commit
that referenced
this pull request
Jul 6, 2023
… use CmdRunner (#6867) locale_gen: refactor module to use CmdRunner (#6820) * refactor module to use CmdRunner * add changelog frag (cherry picked from commit 601fa0d) Co-authored-by: Alexei Znamensky <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Refactor module to use
CmdRunner
.ISSUE TYPE
COMPONENT NAME
locale_gen