Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

locale_gen: refactor module to use CmdRunner #6820

Merged

Conversation

russoz
Copy link
Collaborator

@russoz russoz commented Jun 30, 2023

SUMMARY

Refactor module to use CmdRunner.

ISSUE TYPE
  • Refactoring Pull Request
COMPONENT NAME

locale_gen

@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added module module module_utils module_utils plugins plugin (any type) labels Jun 30, 2023
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-7 labels Jun 30, 2023
@felixfontein
Copy link
Collaborator

(Also this needs a changelog fragment :) )

@russoz
Copy link
Collaborator Author

russoz commented Jun 30, 2023

yup, I am waiting for the CI to run, to make sure we're good

@felixfontein felixfontein merged commit 601fa0d into ansible-collections:main Jul 6, 2023
@patchback
Copy link

patchback bot commented Jul 6, 2023

Backport to stable-7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-7/601fa0df6281db8ed9c7af8916f098faa9528728/pr-6820

Backported as #6867

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein
Copy link
Collaborator

@russoz thanks!

patchback bot pushed a commit that referenced this pull request Jul 6, 2023
* refactor module to use CmdRunner

* add changelog frag

(cherry picked from commit 601fa0d)
@russoz russoz deleted the locale-gen-cmdrunner branch July 6, 2023 19:15
felixfontein pushed a commit that referenced this pull request Jul 6, 2023
… use CmdRunner (#6867)

locale_gen: refactor module to use CmdRunner (#6820)

* refactor module to use CmdRunner

* add changelog frag

(cherry picked from commit 601fa0d)

Co-authored-by: Alexei Znamensky <[email protected]>
@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module_utils module_utils module module plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants