[datadog_downtime] - added 'type' to recurrence object when rrule param is present #6811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
bug
felixfontein
added
check-before-release
|
If nobody objects, I'll merge this by the end of this week. |
felixfontein
removed
the
check-before-release
Backport to stable-6: 💚 backport PR created✅ Backport PR branch: Backported as #6890 🤖 @patchback |
|
@froznsm thanks for your contribution! |
Backport to stable-7: 💚 backport PR created✅ Backport PR branch: Backported as #6891 🤖 @patchback |
felixfontein
pushed a commit
that referenced
this pull request
Jul 8, 2023
…pe' to recurrence object when rrule param is present (#6890) [datadog_downtime] - added 'type' to recurrence object when rrule param is present (#6811) * added 'type' to recurrence object when rrule param is present * formatting cleanup (cherry picked from commit fc74f9a) Co-authored-by: Simon Keil <[email protected]>
felixfontein
pushed a commit
that referenced
this pull request
Jul 8, 2023
…pe' to recurrence object when rrule param is present (#6891) [datadog_downtime] - added 'type' to recurrence object when rrule param is present (#6811) * added 'type' to recurrence object when rrule param is present * formatting cleanup (cherry picked from commit fc74f9a) Co-authored-by: Simon Keil <[email protected]>
valeriopoggi
pushed a commit
to valeriopoggi/community.general
that referenced
this pull request
Jul 17, 2023
…am is present (ansible-collections#6811) * added 'type' to recurrence object when rrule param is present * formatting cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The
datadog_downtimemodule includes the optionalrruleparameter to provide the recurrence for a downtime in the rrule-format. The datadog api client that the module is based on requires that the recurrence type is set as "rrule", which was not done in the module thus far. Whenever therruleparam was populated, the API would return aBad Requestwith the response{'errors': ['Invalid recurrence type']}.This change simply fixes this by adding the type when the param is present.
ISSUE TYPE
COMPONENT NAME
datadog_downtime module