-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plugins/inventory/cobbler: Collect IP addresses for hosts and add opt… #6711
plugins/inventory/cobbler: Collect IP addresses for hosts and add opt… #6711
Conversation
c99940e
to
f96ddd8
Compare
This comment was marked as outdated.
This comment was marked as outdated.
bb59d94
to
ef681ef
Compare
One question I have is whether or not it is okay to simply add the |
One problem with such generic names is that you can likely interfere with existing uses of these names in existing playbooks, roles, or inventories. Usually it's better to prefix them with something that's specific to this inventory plugin; for example, the community.docker.docker_containers inventory plugin prefixes everything with |
Yeah, I'm going to think about it for a little bit, but I think that a |
Though I think |
…ion to collect all DNS name to IP address mappings
ef681ef
to
02187c0
Compare
If nobody objects, I'll merge this by tomorrow morning. |
Backport to stable-7: 💚 backport PR created✅ Backport PR branch: Backported as #6727 🤖 @patchback |
@opoplawski thanks for your contribution! |
…lect IP addresses for hosts and add opt… (#6727) plugins/inventory/cobbler: Collect IP addresses for hosts and add opt… (#6711) plugins/inventory/cobbler: Collect IP addresses for hosts and add option to collect all DNS name to IP address mappings (cherry picked from commit 24f27a0) Co-authored-by: Orion Poplawski <[email protected]>
…ion to collect all DNS name to IP address mappings
SUMMARY
It can be very helpful to have easy access to a host's primary IP address and various DNS name to IP address mappings defined in cobbler.
ISSUE TYPE
COMPONENT NAME
plugins/inventory/cobbler.py
ADDITIONAL INFORMATION