ldap: Add client certificate support #6668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
WIP
There was a problem hiding this comment.
Thanks for your contribution!
Please also modify the modules so that they pass required_together=[('client_cert', 'client_key')] to AnsibleModule(). That way the argument spec validation ensures that the user gets a nice error message if they only provide one of the two.
felixfontein
added
check-before-release
felixfontein
approved these changes
Jun 11, 2023
felixfontein
removed
the
check-before-release
Backport to stable-7: 💚 backport PR created✅ Backport PR branch: Backported as #6696 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jun 15, 2023
* Set up secure ldap server * ldap: Added client cert options Shamelessly copied from https://github.com/andrewshulgin/ldap_search * Added tests for ldap client authentication * Add changelog fragment * Make sure the openssl commands work on older versions of openssl * Apply suggestions from code review Co-authored-by: Felix Fontein <[email protected]> * Remove aliases for new arguments * Add required_together to ldap module declerations --------- Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit f3ecf4c)
|
@Gnonthgol thanks for implementing this! |
felixfontein
pushed a commit
that referenced
this pull request
Jun 15, 2023
…upport (#6696) ldap: Add client certificate support (#6668) * Set up secure ldap server * ldap: Added client cert options Shamelessly copied from https://github.com/andrewshulgin/ldap_search * Added tests for ldap client authentication * Add changelog fragment * Make sure the openssl commands work on older versions of openssl * Apply suggestions from code review Co-authored-by: Felix Fontein <[email protected]> * Remove aliases for new arguments * Add required_together to ldap module declerations --------- Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit f3ecf4c) Co-authored-by: Gnonthgol <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Add new arguments
client_certandclient_keyto the ldap modules in order to allow certificate authentication.Fixes #4066
ISSUE TYPE
COMPONENT NAME
plugins/module_utils/ldap.py
ADDITIONAL INFORMATION
The functional part of the code is copied from work by @andrewshulgin with tests added by myself.