Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add service account token #6659

Closed
wants to merge 1 commit into from
Closed

add service account token #6659

wants to merge 1 commit into from

Conversation

Domi-cc
Copy link
Contributor

@Domi-cc Domi-cc commented Jun 9, 2023

SUMMARY

add new service_account_token for onepassword lookup

Fixes #6635

minor_changes:

  • onepassword lookup - adds service_account_token parameters for supporting 1password service accounts
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

onepassword

ADDITIONAL INFORMATION
lookup('community.general.onepassword', 'KITT', vault='Servers', service_account_token='ops_foobar....')

@ansibullbot
Copy link
Collaborator

The test ansible-test sanity --test pep8 [explain] failed with 10 errors:

plugins/lookup/onepassword.py:129:11: E111: indentation is not a multiple of 4
plugins/lookup/onepassword.py:130:11: E111: indentation is not a multiple of 4
plugins/lookup/onepassword.py:131:11: E111: indentation is not a multiple of 4
plugins/lookup/onepassword.py:132:15: E111: indentation is not a multiple of 4
plugins/lookup/onepassword.py:133:15: E111: indentation is not a multiple of 4
plugins/lookup/onepassword.py:134:15: E111: indentation is not a multiple of 4
plugins/lookup/onepassword.py:135:15: E111: indentation is not a multiple of 4
plugins/lookup/onepassword.py:136:19: E111: indentation is not a multiple of 4
plugins/lookup/onepassword.py:138:15: E111: indentation is not a multiple of 4
plugins/lookup/onepassword.py:139:15: E111: indentation is not a multiple of 4

The test ansible-test sanity --test pep8 [explain] failed with 10 errors:

plugins/lookup/onepassword.py:129:11: E111: indentation is not a multiple of 4
plugins/lookup/onepassword.py:130:11: E111: indentation is not a multiple of 4
plugins/lookup/onepassword.py:131:11: E111: indentation is not a multiple of 4
plugins/lookup/onepassword.py:132:15: E111: indentation is not a multiple of 4
plugins/lookup/onepassword.py:133:15: E111: indentation is not a multiple of 4
plugins/lookup/onepassword.py:134:15: E111: indentation is not a multiple of 4
plugins/lookup/onepassword.py:135:15: E111: indentation is not a multiple of 4
plugins/lookup/onepassword.py:136:19: E111: indentation is not a multiple of 4
plugins/lookup/onepassword.py:138:15: E111: indentation is not a multiple of 4
plugins/lookup/onepassword.py:139:15: E111: indentation is not a multiple of 4

The test ansible-test sanity --test pep8 [explain] failed with 10 errors:

plugins/lookup/onepassword.py:129:11: E111: indentation is not a multiple of 4
plugins/lookup/onepassword.py:130:11: E111: indentation is not a multiple of 4
plugins/lookup/onepassword.py:131:11: E111: indentation is not a multiple of 4
plugins/lookup/onepassword.py:132:15: E111: indentation is not a multiple of 4
plugins/lookup/onepassword.py:133:15: E111: indentation is not a multiple of 4
plugins/lookup/onepassword.py:134:15: E111: indentation is not a multiple of 4
plugins/lookup/onepassword.py:135:15: E111: indentation is not a multiple of 4
plugins/lookup/onepassword.py:136:19: E111: indentation is not a multiple of 4
plugins/lookup/onepassword.py:138:15: E111: indentation is not a multiple of 4
plugins/lookup/onepassword.py:139:15: E111: indentation is not a multiple of 4

The test ansible-test sanity --test pep8 [explain] failed with 10 errors:

plugins/lookup/onepassword.py:129:11: E111: indentation is not a multiple of 4
plugins/lookup/onepassword.py:130:11: E111: indentation is not a multiple of 4
plugins/lookup/onepassword.py:131:11: E111: indentation is not a multiple of 4
plugins/lookup/onepassword.py:132:15: E111: indentation is not a multiple of 4
plugins/lookup/onepassword.py:133:15: E111: indentation is not a multiple of 4
plugins/lookup/onepassword.py:134:15: E111: indentation is not a multiple of 4
plugins/lookup/onepassword.py:135:15: E111: indentation is not a multiple of 4
plugins/lookup/onepassword.py:136:19: E111: indentation is not a multiple of 4
plugins/lookup/onepassword.py:138:15: E111: indentation is not a multiple of 4
plugins/lookup/onepassword.py:139:15: E111: indentation is not a multiple of 4

click here for bot help

@ansibullbot
Copy link
Collaborator

cc @azenk @samdoran @scottsb
click here for bot help

@ansibullbot ansibullbot added feature This issue/PR relates to a feature request lookup lookup plugin needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR new_contributor Help guide this first time contributor plugins plugin (any type) labels Jun 9, 2023
@Domi-cc Domi-cc closed this Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature This issue/PR relates to a feature request lookup lookup plugin needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

onepassword lookup with service account
2 participants
@Domi-cc @ansibullbot