plugins/modules/ldap_search: Add support for multipage searches #6648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
WIP
felixfontein
added
check-before-release
felixfontein
reviewed
Jun 9, 2023
Co-authored-by: Felix Fontein <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
felixfontein
approved these changes
Jun 11, 2023
felixfontein
removed
the
check-before-release
Backport to stable-7: 💚 backport PR created✅ Backport PR branch: Backported as #6697 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jun 15, 2023
* Add more integration tests for ldap_search * Add new page_size option to ldap_search * Add changelog fragment * Apply suggestions from code review Co-authored-by: Felix Fontein <[email protected]> * Simplify if statement to reduce negatives * Apply suggestions from code review Co-authored-by: Felix Fontein <[email protected]> --------- Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit 8801463)
|
@Gnonthgol thanks for implementing this! |
felixfontein
pushed a commit
that referenced
this pull request
Jun 15, 2023
…dd support for multipage searches (#6697) plugins/modules/ldap_search: Add support for multipage searches (#6648) * Add more integration tests for ldap_search * Add new page_size option to ldap_search * Add changelog fragment * Apply suggestions from code review Co-authored-by: Felix Fontein <[email protected]> * Simplify if statement to reduce negatives * Apply suggestions from code review Co-authored-by: Felix Fontein <[email protected]> --------- Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit 8801463) Co-authored-by: Gnonthgol <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Add a new
page_sizeoption to ldap_search to enable paged searches.ISSUE TYPE
COMPONENT NAME
plugins/modules/ldap_search.py