Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

respawn copr module when dnf is missing #6522

Merged
merged 2 commits into from
May 29, 2023

Conversation

gotmax23
Copy link
Contributor

SUMMARY

copr - respawn module to use the system python interpreter when the dnf python module is not available in ansible_python_interpreter

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

copr

ADDITIONAL INFORMATION

Fixes downstream bug https://bugzilla.redhat.com/2203513

Can we backport this to stable-6 and stable-7 so it shows up in ansible 7 and 8? I plan to backport this to the EPEL 8 and 9 ansible-collection-community-general RPM packages that currently contain upstream EOL versions1.

Footnotes

  1. We're updating to upstream supported versions prior to the next RHEL minor release.

@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added WIP Work in progress feature This issue/PR relates to a feature request integration tests/integration module module plugins plugin (any type) tests tests labels May 13, 2023
@gotmax23 gotmax23 marked this pull request as ready for review May 13, 2023 18:06
@ansibullbot ansibullbot removed the WIP Work in progress label May 13, 2023
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-7 labels May 13, 2023
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@gotmax23
Copy link
Contributor Author

Any chance you can also backport this to stable-6 so it gets in the next ansible 7 release or is stable-6 in bugfix only mode?

@felixfontein
Copy link
Collaborator

stable-6 is already bugfix only (basically since the last minor 6.x.0 release before the 7.0.0 release date).

Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be merged for 7.1.0.

@ansibullbot ansibullbot added the stale_ci CI is older than 7 days, rerun before merging label May 22, 2023
@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label May 29, 2023
@felixfontein felixfontein merged commit bd6cec2 into ansible-collections:main May 29, 2023
@patchback
Copy link

patchback bot commented May 29, 2023

Backport to stable-7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-7/bd6cec2105c8d575d20d1e3889a6d26b5ce0377e/pr-6522

Backported as #6591

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein
Copy link
Collaborator

@gotmax23 thanks for your contribution!

patchback bot pushed a commit that referenced this pull request May 29, 2023
* respawn copr module when dnf is missing

Fixes: https://bugzilla.redhat.com/2203513

* don't guard common.respawn module_util import

(cherry picked from commit bd6cec2)
felixfontein pushed a commit that referenced this pull request May 29, 2023
…s missing (#6591)

respawn copr module when dnf is missing (#6522)

* respawn copr module when dnf is missing

Fixes: https://bugzilla.redhat.com/2203513

* don't guard common.respawn module_util import

(cherry picked from commit bd6cec2)

Co-authored-by: Maxwell G <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This issue/PR relates to a feature request integration tests/integration module module plugins plugin (any type) stale_ci CI is older than 7 days, rerun before merging tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants