Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mas: disable sign-in check for macOS 12+ #6520

Merged
merged 11 commits into from
May 29, 2023
Merged

mas: disable sign-in check for macOS 12+ #6520

merged 11 commits into from
May 29, 2023

Conversation

justinpjose
Copy link
Contributor

@justinpjose justinpjose commented May 12, 2023 •
edited by russoz
Loading

SUMMARY

Feature Implementation of Issue - #6519

Fixes #6519

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

mas

ADDITIONAL INFORMATION

Disabling the sign-in check when trying to install or upgrade an app via mas via Ansible for anyone using Mac 12.0+. More details can be found in the issue

@ansibullbot
Copy link
Collaborator

@justinpjose: Greetings! Thanks for taking the time to open this pullrequest. In order for the community to handle your pullrequest effectively, we need a bit more information.

Here are the items we could not find in your description:

  • issue type

Please set the description of this pullrequest with this template:
https://raw.githubusercontent.com/ansible/ansible/devel/.github/PULL_REQUEST_TEMPLATE.md

click here for bot help

@ansibullbot
Copy link
Collaborator

cc @lukasbestle @mheap
click here for bot help

@ansibullbot ansibullbot added module module needs_info This issue requires further information. Please answer any outstanding questions needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly new_contributor Help guide this first time contributor plugins plugin (any type) labels May 12, 2023
@justinpjose justinpjose changed the title disable sign-in check for mas for macOS 12+ mas: disable sign-in check for macOS 12+ May 12, 2023
@ansibullbot ansibullbot added feature This issue/PR relates to a feature request and removed needs_info This issue requires further information. Please answer any outstanding questions needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly labels May 12, 2023
@ansibullbot

This comment was marked as outdated.

Sign in to view
@ansibullbot ansibullbot added ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels May 12, 2023
@ansibullbot ansibullbot removed the ci_verified Push fixes to PR branch to re-run CI label May 12, 2023
@ansibullbot

This comment was marked as outdated.

Sign in to view
@ansibullbot ansibullbot added the ci_verified Push fixes to PR branch to re-run CI label May 12, 2023
@ansibullbot ansibullbot removed the ci_verified Push fixes to PR branch to re-run CI label May 12, 2023
@ansibullbot

This comment was marked as outdated.

Sign in to view
@ansibullbot ansibullbot added the ci_verified Push fixes to PR branch to re-run CI label May 12, 2023
lukasbestle
lukasbestle reviewed May 12, 2023
View reviewed changes
Copy link

@lukasbestle lukasbestle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR. I currently don't actively use Ansible, but I think your solution is the only viable workaround.

@ansibullbot ansibullbot removed ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels May 12, 2023
russoz
russoz reviewed May 13, 2023
View reviewed changes
@felixfontein felixfontein added the check-before-release PR will be looked at again shortly before release and merged if possible. label May 13, 2023
felixfontein
felixfontein reviewed May 13, 2023
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Could you please add a changelog fragment? Thanks.

justinpjose and others added 5 commits May 13, 2023 22:51
@ansibullbot ansibullbot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels May 13, 2023
@justinpjose
Copy link
Contributor Author

@lukasbestle, @russoz, @felixfontein
Thank you for reviewing my PR and giving suggestions. I have addressed all the comments which you have given.

russoz
russoz approved these changes May 14, 2023
View reviewed changes
Copy link
Collaborator

@russoz russoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

felixfontein
felixfontein approved these changes May 14, 2023
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be merged for 7.1.0.

@ansibullbot ansibullbot added the stale_ci CI is older than 7 days, rerun before merging label May 26, 2023
@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label May 29, 2023
@felixfontein felixfontein merged commit 4373f2f into ansible-collections:main May 29, 2023
@patchback
Copy link

patchback bot commented May 29, 2023 •
edited
Loading

Backport to stable-7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-7/4373f2f33b8e89fa87613aeb60d07b0a07c972c8/pr-6520

Backported as #6592

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request May 29, 2023
@justinpjose @patchback
mas: disable sign-in check for macOS 12+ (#6520)
b035f6f 
* disable sign-in check for macOS 12+

* move is_version_greater func outside class Mas

* fix formatting

* remove trailing whitespace

* make use of LooseVersion to compare versions

* update requirement description

Co-authored-by: Felix Fontein <[email protected]>

* update requirement description link

Co-authored-by: Felix Fontein <[email protected]>

* update constant of macOS version

Co-authored-by: Felix Fontein <[email protected]>

* use updated constant

Co-authored-by: Felix Fontein <[email protected]>

* update getting macOS version

Co-authored-by: Felix Fontein <[email protected]>

* add changelog fragment

---------

Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit 4373f2f)
@patchback patchback bot mentioned this pull request May 29, 2023
Merged
@felixfontein
Copy link
Collaborator

@justinpjose thanks for your contribution!
@lukasbestle @russoz thanks for reviewing!

felixfontein pushed a commit that referenced this pull request May 29, 2023
@patchback @justinpjose
[PR #6520/4373f2f3 backport][stable-7] mas: disable sign-in check for…
131bf72 
… macOS 12+ (#6592)

mas: disable sign-in check for macOS 12+ (#6520)

* disable sign-in check for macOS 12+

* move is_version_greater func outside class Mas

* fix formatting

* remove trailing whitespace

* make use of LooseVersion to compare versions

* update requirement description

Co-authored-by: Felix Fontein <[email protected]>

* update requirement description link

Co-authored-by: Felix Fontein <[email protected]>

* update constant of macOS version

Co-authored-by: Felix Fontein <[email protected]>

* use updated constant

Co-authored-by: Felix Fontein <[email protected]>

* update getting macOS version

Co-authored-by: Felix Fontein <[email protected]>

* add changelog fragment

---------

Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit 4373f2f)

Co-authored-by: Justine Jose <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasbestle lukasbestle lukasbestle left review comments

@russoz russoz russoz approved these changes

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
feature This issue/PR relates to a feature request module module new_contributor Help guide this first time contributor plugins plugin (any type) stale_ci CI is older than 7 days, rerun before merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mas - remove signed-in check from Mac OS 12.0+
5 participants
@justinpjose @ansibullbot @felixfontein @russoz @lukasbestle