ldap_search: make sure output is always UTF-8 (by allowing to Base64 encode specific values, and force-converting everything else) #6475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
bug
1 task
felixfontein
added
the
breaking_change
|
@russoz thanks for reviewing this! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #5704.
This contains a breaking change: it force-converts all output to UTF-8. That's why I don't want to backport this (as a bugfix).
It also allows to specify a list of attributes whose values will be Base64 encoded. This should be used if a caller actually relies on some binary values.
ISSUE TYPE
COMPONENT NAME
ldap_search