snap: aware of channel in installed snaps #6435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
WIP
felixfontein
added
the
check-before-release
ansibullbot
added
the
needs_rebase
|
This is a welcome approach, any progress? |
ansibullbot
removed
needs_rebase
This comment was marked as resolved.
This comment was marked as resolved.
hi @Teebor-Choka I could not put much time on this in the last couple of weeks. Will try to work on it this weekend. |
russoz
changed the title
ansibullbot
added
needs_ci
felixfontein
reviewed
Jun 5, 2023
|
@felixfontein you mentioned a small comment as well, but there was nothing here. Anyways, the changelog frag is already pushed. |
felixfontein
reviewed
Jun 6, 2023
Co-authored-by: Felix Fontein <[email protected]>
Backport to stable-7: 💚 backport PR created✅ Backport PR branch: Backported as #6630 🤖 @patchback |
felixfontein
removed
the
check-before-release
|
@russoz thanks! |
patchback bot
pushed a commit
that referenced
this pull request
Jun 6, 2023
* [WIP] snap: aware of channel in installed snaps * parse snap list output and assert whether channel matches * undo test * fail rightfully when install with different channel does not work * transparetent refresh * rollback comment in integration test * rollback comment in integration test * add changelog frag * Update plugins/modules/snap.py Co-authored-by: Felix Fontein <[email protected]> --------- Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit b78d199)
felixfontein
pushed a commit
that referenced
this pull request
Jun 6, 2023
…alled snaps (#6630) snap: aware of channel in installed snaps (#6435) * [WIP] snap: aware of channel in installed snaps * parse snap list output and assert whether channel matches * undo test * fail rightfully when install with different channel does not work * transparetent refresh * rollback comment in integration test * rollback comment in integration test * add changelog frag * Update plugins/modules/snap.py Co-authored-by: Felix Fontein <[email protected]> --------- Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit b78d199) Co-authored-by: Alexei Znamensky <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Currently the
snapmodule is not aware of the the snap channel when identifying installed snaps. This PR fixes that.Fixes: #1606
ISSUE TYPE
COMPONENT NAME
snap