Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated to use the new newrelic v2 api #5341

Merged
merged 9 commits into from
Oct 12, 2022
Merged

Updated to use the new newrelic v2 api #5341

merged 9 commits into from
Oct 12, 2022

Conversation

wliao008
Copy link
Contributor

@wliao008 wliao008 commented Oct 5, 2022

SUMMARY

This fixes #4758

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

community.general.newrelic_deployment

ADDITIONAL INFORMATION

The NewRelic v2 API has changed, app_name is gone, application_id is now required. See https://docs.newrelic.com/docs/apm/new-relic-apm/maintenance/record-monitor-deployments/

weiliao @ ~/Programming/community.general/plugins/modules/monitoring  (newrelic-api-fix)
 [107] → python newrelic_deployment.py /tmp/args.json 

{"changed": true, "invocation": {"module_args": {"token": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "application_id": "85122573", "changelog": "blah", "description": "", "revision": "1234567", "user": "Wei Liao", "validate_certs": true}}}

@ansibullbot ansibullbot added bug This issue/PR relates to a bug module module monitoring needs_maintainer new_contributor Help guide this first time contributor plugins plugin (any type) labels Oct 5, 2022
@github-actions
Copy link

github-actions bot commented Oct 5, 2022 •
edited
Loading

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-5 labels Oct 6, 2022
@ansibullbot ansibullbot added stale_ci CI is older than 7 days, rerun before merging and removed stale_ci CI is older than 7 days, rerun before merging labels Oct 6, 2022
felixfontein
felixfontein reviewed Oct 8, 2022
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Please note that there was an earlier PR to fix this (#1501).

Please add a changelog fragment.

felixfontein
felixfontein reviewed Oct 10, 2022
View reviewed changes
russoz
russoz reviewed Oct 10, 2022
View reviewed changes
Copy link
Collaborator

@russoz russoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wliao008 thanks for the contribution! I made a couple of comments, most of them are nit-picking.

@ansibullbot ansibullbot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label Oct 11, 2022
russoz
russoz approved these changes Oct 11, 2022
View reviewed changes
Copy link
Collaborator

@russoz russoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felixfontein felixfontein merged commit 7e2a6cf into ansible-collections:main Oct 12, 2022
@patchback
Copy link

patchback bot commented Oct 12, 2022 •
edited
Loading

Backport to stable-5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-5/7e2a6cf1984781c523e62c31084f028226ef200d/pr-5341

Backported as #5354

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Oct 12, 2022
patchback bot pushed a commit that referenced this pull request Oct 12, 2022
@wliao008 @patchback
Updated to use the new newrelic v2 api (#5341)
0e538ff 
* updated to use the new newrelic v2 api

* check that application_id is set

* indenting issue

* added back app_name

* fix import ordering

* resolving various spellings & wordings

* fixed wordings

* validate_certs

* fixed unreachable code

(cherry picked from commit 7e2a6cf)
This was referenced Nov 20, 2022
Closed
Merged
Closed
Closed
Closed
Closed
Merged
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Open
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Dec 1, 2022
Open
Closed
@renovate renovate bot mentioned this pull request Dec 14, 2022
Closed
1 task
@renovate renovate bot mentioned this pull request Jan 1, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@russoz russoz russoz approved these changes

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug module module monitoring needs_maintainer needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

community.general.newrelic_deployment is broken
4 participants
@wliao008 @felixfontein @russoz @ansibullbot