onepassword - Get first found config file #4640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are three valid places to get the configuration. https://developer.1password.com/docs/cli/about-biometric-unlock#remove-old-account-information
ansibullbot
added
bug
samdoran
changed the title
felixfontein
reviewed
May 8, 2022
felixfontein
added
check-before-release
This shouldn’t matter for lookups, but does matter for module_utils and modules since Python 2.7 is still supported on the managed node.
felixfontein
reviewed
May 9, 2022
felixfontein
approved these changes
May 9, 2022
Backport to stable-3: 💚 backport PR created✅ Backport PR branch: Backported as #4652 🤖 @patchback |
|
@samdoran thanks a lot for fixing this! |
patchback bot
pushed a commit
that referenced
this pull request
May 9, 2022
* Get first found configuration file There are three valid places to get the configuration. https://developer.1password.com/docs/cli/about-biometric-unlock#remove-old-account-information * Use common config class * Add changelog fragment * Explicitly use new style classes for Python 2.7 compatibility This shouldn’t matter for lookups, but does matter for module_utils and modules since Python 2.7 is still supported on the managed node. * Update changelogs/fragments/4065-onepassword-config.yml Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit 9e1af2d)
Backport to stable-4: 💚 backport PR created✅ Backport PR branch: Backported as #4653 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
May 9, 2022
* Get first found configuration file There are three valid places to get the configuration. https://developer.1password.com/docs/cli/about-biometric-unlock#remove-old-account-information * Use common config class * Add changelog fragment * Explicitly use new style classes for Python 2.7 compatibility This shouldn’t matter for lookups, but does matter for module_utils and modules since Python 2.7 is still supported on the managed node. * Update changelogs/fragments/4065-onepassword-config.yml Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit 9e1af2d)
felixfontein
removed
the
check-before-release
felixfontein
pushed a commit
that referenced
this pull request
May 9, 2022
* Get first found configuration file There are three valid places to get the configuration. https://developer.1password.com/docs/cli/about-biometric-unlock#remove-old-account-information * Use common config class * Add changelog fragment * Explicitly use new style classes for Python 2.7 compatibility This shouldn’t matter for lookups, but does matter for module_utils and modules since Python 2.7 is still supported on the managed node. * Update changelogs/fragments/4065-onepassword-config.yml Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit 9e1af2d) Co-authored-by: Sam Doran <[email protected]>
felixfontein
pushed a commit
that referenced
this pull request
May 9, 2022
* Get first found configuration file There are three valid places to get the configuration. https://developer.1password.com/docs/cli/about-biometric-unlock#remove-old-account-information * Use common config class * Add changelog fragment * Explicitly use new style classes for Python 2.7 compatibility This shouldn’t matter for lookups, but does matter for module_utils and modules since Python 2.7 is still supported on the managed node. * Update changelogs/fragments/4065-onepassword-config.yml Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit 9e1af2d) Co-authored-by: Sam Doran <[email protected]>
|
Thanks @felixfontein! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #4065.
There are three configuration file locations. Use the first found valid config.
ISSUE TYPE
COMPONENT NAME
plugins/lookup/onepassword.pyplugins/module_utils/onepassword.pyplugins/modules/identity/onepassword_info.pyADDITIONAL INFORMATION
This plugin is currently broken since the 1Password v2 CLI was released. More work is needed to address that issue, but this is a first step.