Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opentelemetry: enrich service for community.docker.docker_login #4104

Merged
merged 2 commits into from
Jan 29, 2022
Merged

opentelemetry: enrich service for community.docker.docker_login #4104

merged 2 commits into from
Jan 29, 2022

Conversation

v1v
Copy link
Contributor

@v1v v1v commented Jan 28, 2022

SUMMARY

Enrich the span metadata for those ansible tasks that interact with community.docker.docker_login.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

callback/opentelemetry.py

ADDITIONAL INFORMATION

Given:

---
# This playbook prints a simple debug message
- name: Echo
  hosts: localhost
  connection: local

  tasks:
    - name: Log into DockerHub
      docker_login:
        username: "{{ docker_user }}"
        password: "{{ docker_password }}"
        registry_url: https://index.docker.io/v1/

And the ElasticStack, then the Service Maps can see below

image

v1v added a commit to v1v/cicd-demo-2022 that referenced this pull request Jan 28, 2022
@v1v
Consume ansible-collections/community.general#4104
7cd1c35
@ansibullbot ansibullbot added callback callback plugin feature This issue/PR relates to a feature request plugins plugin (any type) small_patch Hopefully easy to review labels Jan 28, 2022
@ansibullbot ansibullbot removed the small_patch Hopefully easy to review label Jan 28, 2022
@felixfontein felixfontein added backport-4 check-before-release PR will be looked at again shortly before release and merged if possible. labels Jan 29, 2022
@felixfontein felixfontein merged commit e793e2e into ansible-collections:main Jan 29, 2022
@patchback
Copy link

patchback bot commented Jan 29, 2022 •
edited
Loading

Backport to stable-4: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4/e793e2e94f173c2d9847d528e81d2acd40ff7d11/pr-4104

Backported as #4109

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein
Copy link
Collaborator

@v1v thanks for your contribution!

patchback bot pushed a commit that referenced this pull request Jan 29, 2022
@v1v @patchback
opentelemetry: enrich service for community.docker.docker_login (#4104)
130d318 
* opentelemetry: support service for community.docker.docker_login

* changelog

(cherry picked from commit e793e2e)
@patchback patchback bot mentioned this pull request Jan 29, 2022
Merged
felixfontein pushed a commit that referenced this pull request Jan 29, 2022
@patchback @v1v
opentelemetry: enrich service for community.docker.docker_login (#4104)…
ad1f25e 
… (#4109)

* opentelemetry: support service for community.docker.docker_login

* changelog

(cherry picked from commit e793e2e)

Co-authored-by: Victor Martinez <[email protected]>
@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Jan 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
callback callback plugin feature This issue/PR relates to a feature request plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@v1v @felixfontein @ansibullbot