[PR #3519/8825ef47 backport][stable-4] LXD inventory: Support virtual machines #3900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
* LXD 4.x compatibility (Containers and VMs) * add changelog fragment * update fixture * update plugin options * backwards compatible alias Co-authored-by: Felix Fontein <[email protected]> * Update changelogs/fragments/3519-inventory-support-lxd-4.yml Co-authored-by: Felix Fontein <[email protected]> * add lxd 4.0 requirement * filter for type of virtualization added. due to duplication in the namespace, "type" is not used as the keyword but "nature". * add type filter Since the first version of this inventory plugin only supports containers, a filter function was added to filter between containers and virtual machines or both. By default only containers are displayed, as in the first version of the plugin. This behavior will change in the future. * rename C(nature) to C(type) The term "nature" does not fit into the lxd namespace. Therefore i renamed nature to type. * update changelog fragment * Update plugins/inventory/lxd.py Co-authored-by: Felix Fontein <[email protected]> * Apply suggestions from code review Co-authored-by: Felix Fontein <[email protected]> * rename typefilter to type_filter * fix tests with type_filter * Update plugins/inventory/lxd.py * Update plugins/inventory/lxd.py Co-authored-by: Felix Fontein <[email protected]> Co-authored-by: Frank Dornheim <“[email protected]@users.noreply.github.com”> (cherry picked from commit 8825ef4)
ansibullbot
added
backport
feature
felixfontein
deleted the
patchback/backports/stable-4/8825ef4711ab44598f9e480b3d5ea75c608701c8/pr-3519
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #3519 as merged into main (8825ef4).
SUMMARY
Adds full compatibility for LXD 4.x. It allows to list containers and VMs
The plugin is already only compatible with LXD 4 (due to a call to
/1.0/networks/{interface}/state), this PR adds requirement and VM supportISSUE TYPE
COMPONENT NAME
lxd inventory plugin
ADDITIONAL INFORMATION
I renamed "container" to "instance" (sed) and fixed some specific needs: L611, L632, L636, L649
My LXD instances:
Before (containers only):
After (containers and VM):