fix modules' output by using publish_cmd #3655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
bug
felixfontein
reviewed
Nov 1, 2021
Co-authored-by: Felix Fontein <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
Yup,, that occurred to me after sending the PR. The impact is small enough for me to care not. So, if you agree with me, then just hit it. Otherwise we need to discuss options. |
|
I could change it to a minor_change as well |
|
@russoz no, the current form is fine I think :) Just wanted to point it out so we don't accidentally try to backport it later ;) |
|
@russoz thanks for this improvement! |
JonEllis
pushed a commit
to JonEllis/community.general
that referenced
this pull request
Nov 16, 2021
* fix modules' output by using publish_cmd * added changelog frag * Update changelogs/fragments/3655-use-publish_cmd.yaml Co-authored-by: Felix Fontein <[email protected]> * Update changelogs/fragments/3655-use-publish_cmd.yaml Co-authored-by: Felix Fontein <[email protected]> * Update changelogs/fragments/3655-use-publish_cmd.yaml Co-authored-by: Felix Fontein <[email protected]> Co-authored-by: Felix Fontein <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
These three modules have the same mechanics: they run a "state gathering" function before and after executing the actual command. Because we lacked the
publish_cmdoption inMH.run_command(), the output valuecmd_argswould always contain the arguments of the after-state-gathering call. Instead, what made sense was to show the command actually executed.ISSUE TYPE
COMPONENT NAME
plugins/modules/packaging/language/ansible_galaxy_install.py
plugins/modules/packaging/language/pipx.py
plugins/modules/packaging/os/snap_alias.py