gitlab_project_members: improve project name matching #3602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The actual search method doesn't accept path with namespace for project_name. If you have many project with same name, this module gitlab_project_members can't work.
ansibullbot
added
bug
There was a problem hiding this comment.
Thanks for your contribution! Can you please add a changelog fragment?
About the change itself: is it possible to do something similar to https://github.com/ansible-collections/community.general/pull/3400/files instead?
felixfontein
changed the title
felixfontein
added
the
check-before-release
|
Changelog Done. |
This comment has been minimized.
This comment has been minimized.
ansibullbot
added
ci_verified
ansibullbot
removed
the
needs_revision
|
In case you tried adding a changelog fragment, you forgot to add/push it because it isn't there in this PR yet :) |
|
Yes you're right. It's all good now. |
This comment has been minimized.
This comment has been minimized.
ansibullbot
added
ci_verified
…fix-gitlab_project_members-improve-search-method.yml
ansibullbot
removed
ci_verified
felixfontein
approved these changes
Oct 24, 2021
|
If nobody complains, I'll merge this weekend. |
felixfontein
removed
the
check-before-release
Backport to stable-2: 💚 backport PR created✅ Backport PR branch: Backported as #3635 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Oct 30, 2021
* Update gitlab_project_members.py The actual search method doesn't accept path with namespace for project_name. If you have many project with same name, this module gitlab_project_members can't work. * Update gitlab_project_members.py * Update gitlab_project_members.py * Update gitlab_project_members.py * Create 3602-fix-gitlab_project_members-improve-search-method * Rename 3602-fix-gitlab_project_members-improve-search-method to 3602-fix-gitlab_project_members-improve-search-method.yml (cherry picked from commit cdfc4dc)
Backport to stable-3: 💚 backport PR created✅ Backport PR branch: Backported as #3636 🤖 @patchback |
|
@paytroff thanks for fixing this! |
patchback bot
pushed a commit
that referenced
this pull request
Oct 30, 2021
* Update gitlab_project_members.py The actual search method doesn't accept path with namespace for project_name. If you have many project with same name, this module gitlab_project_members can't work. * Update gitlab_project_members.py * Update gitlab_project_members.py * Update gitlab_project_members.py * Create 3602-fix-gitlab_project_members-improve-search-method * Rename 3602-fix-gitlab_project_members-improve-search-method to 3602-fix-gitlab_project_members-improve-search-method.yml (cherry picked from commit cdfc4dc)
felixfontein
pushed a commit
that referenced
this pull request
Oct 30, 2021
* Update gitlab_project_members.py The actual search method doesn't accept path with namespace for project_name. If you have many project with same name, this module gitlab_project_members can't work. * Update gitlab_project_members.py * Update gitlab_project_members.py * Update gitlab_project_members.py * Create 3602-fix-gitlab_project_members-improve-search-method * Rename 3602-fix-gitlab_project_members-improve-search-method to 3602-fix-gitlab_project_members-improve-search-method.yml (cherry picked from commit cdfc4dc) Co-authored-by: paytroff <[email protected]>
felixfontein
pushed a commit
that referenced
this pull request
Oct 30, 2021
* Update gitlab_project_members.py The actual search method doesn't accept path with namespace for project_name. If you have many project with same name, this module gitlab_project_members can't work. * Update gitlab_project_members.py * Update gitlab_project_members.py * Update gitlab_project_members.py * Create 3602-fix-gitlab_project_members-improve-search-method * Rename 3602-fix-gitlab_project_members-improve-search-method to 3602-fix-gitlab_project_members-improve-search-method.yml (cherry picked from commit cdfc4dc) Co-authored-by: paytroff <[email protected]>
JonEllis
pushed a commit
to JonEllis/community.general
that referenced
this pull request
Nov 16, 2021
…tions#3602) * Update gitlab_project_members.py The actual search method doesn't accept path with namespace for project_name. If you have many project with same name, this module gitlab_project_members can't work. * Update gitlab_project_members.py * Update gitlab_project_members.py * Update gitlab_project_members.py * Create 3602-fix-gitlab_project_members-improve-search-method * Rename 3602-fix-gitlab_project_members-improve-search-method to 3602-fix-gitlab_project_members-improve-search-method.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actual search method doesn't accept path with namespace for project_name. If you have many project with same name, this module gitlab_project_members can't work.
SUMMARY
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION