Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

terraform: add parallelism parameter #3540

Merged
merged 2 commits into from
Oct 11, 2021
Merged

terraform: add parallelism parameter #3540

merged 2 commits into from
Oct 11, 2021

Conversation

linxside
Copy link
Contributor

@linxside linxside commented Oct 9, 2021

SUMMARY

This PR adds the parallelism parameter to the terraform module.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
  • terraform

@ansibullbot
Copy link
Collaborator

cc @m-yosefpor @rainerleber
click here for bot help

@ansibullbot ansibullbot added cloud feature This issue/PR relates to a feature request module module new_contributor Help guide this first time contributor plugins plugin (any type) labels Oct 9, 2021
felixfontein
felixfontein reviewed Oct 9, 2021
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

plugins/modules/cloud/misc/terraform.py Show resolved Hide resolved
plugins/modules/cloud/misc/terraform.py Show resolved Hide resolved
felixfontein
felixfontein approved these changes Oct 10, 2021
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a safe feature to me in the sense that it shouldn't break anything that worked so far. (I can't judge the change itself since I'm not familiar with terraform at all.)

@felixfontein felixfontein added backport-3 check-before-release PR will be looked at again shortly before release and merged if possible. labels Oct 10, 2021
@m-yosefpor
Copy link
Contributor

@felixfontein yes it's completely safe.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Oct 11, 2021
@felixfontein felixfontein merged commit ed2c1e4 into ansible-collections:main Oct 11, 2021
@patchback
Copy link

patchback bot commented Oct 11, 2021 •
edited
Loading

Backport to stable-3: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-3/ed2c1e4ac906185c9103a9a7dc07afbf3396cc18/pr-3540

Backported as #3547

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Oct 11, 2021
@linxside
terraform: add parallelism parameter (#3540)
b6a0b80 
* terraform: add parallelism parameter

* terraform: add parallelism parameter version

(cherry picked from commit ed2c1e4)
@patchback patchback bot mentioned this pull request Oct 11, 2021
Merged
@felixfontein
Copy link
Collaborator

@linxside thanks for your contribution!
@m-yosefpor thanks for reviewing!

felixfontein pushed a commit that referenced this pull request Oct 11, 2021
@patchback @linxside
terraform: add parallelism parameter (#3540) (#3547)
c01ce10 
* terraform: add parallelism parameter

* terraform: add parallelism parameter version

(cherry picked from commit ed2c1e4)

Co-authored-by: linxside <[email protected]>
JonEllis pushed a commit to JonEllis/community.general that referenced this pull request Nov 16, 2021
@linxside @JonEllis
terraform: add parallelism parameter (ansible-collections#3540)
865ec60 
* terraform: add parallelism parameter

* terraform: add parallelism parameter version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
cloud feature This issue/PR relates to a feature request module module new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@linxside @ansibullbot @m-yosefpor @felixfontein