Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated options, aliases and defaults #3461

Merged
merged 7 commits into from
Oct 12, 2021
Merged

Remove deprecated options, aliases and defaults #3461

merged 7 commits into from
Oct 12, 2021

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

Remove deprecations for 4.0.0.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

various modules and module utils

@felixfontein felixfontein added the breaking_change This PR contains a breaking change that MUST NOT be backported label Sep 28, 2021
@ansibullbot ansibullbot added WIP Work in progress cloud feature This issue/PR relates to a feature request language module module module_utils module_utils notification packaging plugins plugin (any type) system labels Sep 28, 2021
@ansibullbot ansibullbot added the tests tests label Sep 28, 2021
@felixfontein felixfontein changed the title [WIP] Remove deprecated options, aliases and defaults Remove deprecated options, aliases and defaults Sep 28, 2021
@felixfontein
Copy link
Collaborator Author

ready_for_review

@ansibullbot ansibullbot removed the WIP Work in progress label Sep 28, 2021
@ansibullbot
Copy link
Collaborator

cc @Ajpantuso @Thulium-Drake @UnderGreen @fcuny @helldorado @jbenden @joshainglis @jsumners @karmab @LOMS @lomserman @russoz @tleguern @tyouxa @zimbatm
click here for bot help

Ajpantuso
Ajpantuso requested changes Sep 28, 2021
View reviewed changes
Copy link
Collaborator

@Ajpantuso Ajpantuso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some docs suggestions for the Proxmox modules, but otherwise looks good.

plugins/modules/cloud/misc/proxmox.py Outdated Show resolved Hide resolved
plugins/modules/cloud/misc/proxmox_kvm.py Outdated Show resolved Hide resolved
@ansibullbot ansibullbot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label Sep 28, 2021
@ansibullbot ansibullbot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI and removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI labels Sep 29, 2021
@ansibullbot

This comment has been minimized.

Sign in to view
@ansibullbot ansibullbot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Sep 29, 2021
@felixfontein felixfontein mentioned this pull request Sep 30, 2021
Open
1 task
@ansibullbot ansibullbot added stale_ci CI is older than 7 days, rerun before merging stale_review has_issue labels Oct 7, 2021
Ajpantuso
Ajpantuso approved these changes Oct 10, 2021
View reviewed changes
Copy link
Collaborator

@Ajpantuso Ajpantuso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ansibullbot ansibullbot removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR stale_review labels Oct 10, 2021
@felixfontein
Copy link
Collaborator Author

Will merge once CI passes; from then on main will be preparing 4.0.0.

@ansibullbot ansibullbot removed the stale_ci CI is older than 7 days, rerun before merging label Oct 12, 2021
@felixfontein felixfontein merged commit 9546bbb into ansible-collections:main Oct 12, 2021
@felixfontein felixfontein deleted the remove-deprecated branch October 12, 2021 11:56
@felixfontein
Copy link
Collaborator Author

@Ajpantuso @russoz thanks for reviewing this!

JonEllis pushed a commit to JonEllis/community.general that referenced this pull request Nov 16, 2021
@felixfontein @Ajpantuso
@russoz @JonEllis
Remove deprecated options, aliases and defaults (ansible-collections#…
5199a88 
…3461)

* Remove deprecated options, aliases and defaults.

* Add changelog fragment.

* Small fixes.

* Apply suggestions from code review

Co-authored-by: Ajpantuso <[email protected]>

* Lint.

* Update plugins/modules/system/xfconf.py

Co-authored-by: Alexei Znamensky <[email protected]>

* Bump galaxy version to 4.0.0.

Co-authored-by: Ajpantuso <[email protected]>
Co-authored-by: Alexei Znamensky <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@russoz russoz russoz left review comments

@Ajpantuso Ajpantuso Ajpantuso approved these changes

Assignees
No one assigned
Labels
breaking_change This PR contains a breaking change that MUST NOT be backported cloud feature This issue/PR relates to a feature request has_issue language module_utils module_utils module module notification packaging plugins plugin (any type) system tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@felixfontein @ansibullbot @russoz @Ajpantuso