Get behavior of gitlab_project_members to the one of gitlab_group_members #3319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w gitlab_group_members
ansibullbot
added
affects_2.10
community_review
feature
felixfontein
added
backport-3
check-before-release
|
Follow-up to #3047. |
felixfontein
reviewed
Sep 1, 2021
plugins/modules/source_control/gitlab/gitlab_project_members.py
Outdated
Show resolved
Hide resolved
plugins/modules/source_control/gitlab/gitlab_project_members.py
Outdated
Show resolved
Hide resolved
plugins/modules/source_control/gitlab/gitlab_project_members.py
Outdated
Show resolved
Hide resolved
plugins/modules/source_control/gitlab/gitlab_project_members.py
Outdated
Show resolved
Hide resolved
plugins/modules/source_control/gitlab/gitlab_project_members.py
Outdated
Show resolved
Hide resolved
plugins/modules/source_control/gitlab/gitlab_project_members.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Felix Fontein <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
felixfontein
reviewed
Sep 6, 2021
Hey, sorry about that. Had to disable an editor plugin to prevent those changes. Hope I found all of them. |
felixfontein
approved these changes
Sep 10, 2021
|
If nobody complains, I'll merge this in ~a week. |
ansibullbot
removed
needs_ci
felixfontein
removed
the
check-before-release
Backport to stable-3: 💚 backport PR created✅ Backport PR branch: Backported as #3383 🤖 @patchback |
|
@suukit thanks for implementing this! |
patchback bot
pushed a commit
that referenced
this pull request
Sep 16, 2021
…bers (#3319) * Initial change to get behaviour of gitlab_project_members like the new gitlab_group_members * added changelog * linter: removed trainling whitespaces * Update plugins/modules/source_control/gitlab/gitlab_project_members.py Co-authored-by: Felix Fontein <[email protected]> * Update plugins/modules/source_control/gitlab/gitlab_project_members.py Co-authored-by: Felix Fontein <[email protected]> * Update plugins/modules/source_control/gitlab/gitlab_project_members.py Co-authored-by: Felix Fontein <[email protected]> * Update plugins/modules/source_control/gitlab/gitlab_project_members.py Co-authored-by: Felix Fontein <[email protected]> * Update plugins/modules/source_control/gitlab/gitlab_project_members.py Co-authored-by: Felix Fontein <[email protected]> * requested changes * linter fixes * undoing formatting changes to existing code Co-authored-by: Max-Florian Bidlingmaier <[email protected]> Co-authored-by: Felix Fontein <[email protected]> Co-authored-by: Max Bidlingmaier <[email protected]> (cherry picked from commit 7a2efb4)
felixfontein
pushed a commit
that referenced
this pull request
Sep 17, 2021
…bers (#3319) (#3383) * Initial change to get behaviour of gitlab_project_members like the new gitlab_group_members * added changelog * linter: removed trainling whitespaces * Update plugins/modules/source_control/gitlab/gitlab_project_members.py Co-authored-by: Felix Fontein <[email protected]> * Update plugins/modules/source_control/gitlab/gitlab_project_members.py Co-authored-by: Felix Fontein <[email protected]> * Update plugins/modules/source_control/gitlab/gitlab_project_members.py Co-authored-by: Felix Fontein <[email protected]> * Update plugins/modules/source_control/gitlab/gitlab_project_members.py Co-authored-by: Felix Fontein <[email protected]> * Update plugins/modules/source_control/gitlab/gitlab_project_members.py Co-authored-by: Felix Fontein <[email protected]> * requested changes * linter fixes * undoing formatting changes to existing code Co-authored-by: Max-Florian Bidlingmaier <[email protected]> Co-authored-by: Felix Fontein <[email protected]> Co-authored-by: Max Bidlingmaier <[email protected]> (cherry picked from commit 7a2efb4) Co-authored-by: Max Bidlingmaier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
gitlab_group_members has been enhanced to accept list of users/access levels and purge users not in list. This change does the same changes to gitlab_project_members
ISSUE TYPE
COMPONENT NAME
gitlab_project_members
@felixfontein @zanssa