Fix keycloak_realm module #3231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add events_enabled parameter
ansibullbot
added
affects_2.10
bug
|
LGTM |
felixfontein
added
backport-3
check-before-release
Co-authored-by: Felix Fontein <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
|
Looks good to me. @kris2kris are you (still) happy as well? |
|
I assume that is a yes. |
felixfontein
removed
the
check-before-release
Backport to stable-3: 💚 backport PR created✅ Backport PR branch: Backported as #3277 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Aug 27, 2021
* fix events_listeners element type add events_enabled parameter * Update plugins/modules/identity/keycloak/keycloak_realm.py Co-authored-by: Felix Fontein <[email protected]> * add changelog * Update changelogs/fragments/3231-fix-keycloak-realm-events.yml Co-authored-by: Felix Fontein <[email protected]> * Update changelogs/fragments/3231-fix-keycloak-realm-events.yml Co-authored-by: Felix Fontein <[email protected]> * Update plugins/modules/identity/keycloak/keycloak_realm.py Co-authored-by: Felix Fontein <[email protected]> Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit 825e17c)
|
@laurpaum thanks for fixing this! |
felixfontein
pushed a commit
that referenced
this pull request
Aug 27, 2021
* fix events_listeners element type add events_enabled parameter * Update plugins/modules/identity/keycloak/keycloak_realm.py Co-authored-by: Felix Fontein <[email protected]> * add changelog * Update changelogs/fragments/3231-fix-keycloak-realm-events.yml Co-authored-by: Felix Fontein <[email protected]> * Update changelogs/fragments/3231-fix-keycloak-realm-events.yml Co-authored-by: Felix Fontein <[email protected]> * Update plugins/modules/identity/keycloak/keycloak_realm.py Co-authored-by: Felix Fontein <[email protected]> Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit 825e17c) Co-authored-by: Laurent Paumier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixed bad element type for events_listeners parameter (string array in Keycloak realm representation).
Added events_enabled parameter to allow activation or deactivation of login events.
ISSUE TYPE
COMPONENT NAME
keycloak_realm