minor refactors on plugins/modules/cloud/misc #2557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
affects_2.10
cloud
community_review
feature
felixfontein
added
backport-3
check-before-release
Co-authored-by: Felix Fontein <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
felixfontein
approved these changes
May 20, 2021
felixfontein
removed
the
check-before-release
Backport to stable-3: 💚 backport PR created✅ Backport PR branch: Backported as #2660 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
May 27, 2021
* minor refactors on plugins/modules/cloud/misc * added changelog fragment * removed unreachable statement * Update plugins/modules/cloud/misc/terraform.py Co-authored-by: Felix Fontein <[email protected]> * Update plugins/modules/cloud/misc/rhevm.py Co-authored-by: Felix Fontein <[email protected]> * adjusted per PR comment Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit 3afcf7e)
|
@russoz thanks for improving the modules! |
felixfontein
pushed a commit
that referenced
this pull request
May 27, 2021
* minor refactors on plugins/modules/cloud/misc * added changelog fragment * removed unreachable statement * Update plugins/modules/cloud/misc/terraform.py Co-authored-by: Felix Fontein <[email protected]> * Update plugins/modules/cloud/misc/rhevm.py Co-authored-by: Felix Fontein <[email protected]> * adjusted per PR comment Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit 3afcf7e) Co-authored-by: Alexei Znamensky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Minor refactors on modules under
plugins/modules/cloud/miscISSUE TYPE
COMPONENT NAME
plugins/modules/cloud/misc/cloud_init_data_facts.py
plugins/modules/cloud/misc/proxmox_group_info.py
plugins/modules/cloud/misc/proxmox_kvm.py
plugins/modules/cloud/misc/rhevm.py
plugins/modules/cloud/misc/serverless.py
plugins/modules/cloud/misc/terraform.py