Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1085 updating the hcl whitelist to include all supported options #2495

Merged
merged 2 commits into from
May 17, 2021
Merged

1085 updating the hcl whitelist to include all supported options #2495

merged 2 commits into from
May 17, 2021

Conversation

iridian-ks
Copy link
Contributor

@iridian-ks iridian-ks commented May 12, 2021 •
edited by felixfontein
Loading

SUMMARY

Fixes #1085 and all possible other tickets related to adding support for all ACL options

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

consul_acl

ADDITIONAL INFORMATION

Full list of rules are here: https://www.consul.io/docs/security/acl/acl-rules

@ansibullbot
Copy link
Collaborator

cc @sgargan
click here for bot help

@ansibullbot ansibullbot added affects_2.10 bug This issue/PR relates to a bug clustering community_review module module needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) stale_ci CI is older than 7 days, rerun before merging labels May 12, 2021
@felixfontein felixfontein mentioned this pull request May 12, 2021
Closed
@felixfontein felixfontein added backport-2 check-before-release PR will be looked at again shortly before release and merged if possible. labels May 12, 2021
@felixfontein
Copy link
Collaborator

(You can ignore the failing third-party-check. It currently fails a lot..)

@felixfontein
Copy link
Collaborator

recheck

1 similar comment
@felixfontein
Copy link
Collaborator

recheck

@iridian-ks
Copy link
Contributor Author

Thank you for making the suggested fix. It's much appreciated.

felixfontein
felixfontein approved these changes May 12, 2021
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot test this and I don't know the code, but it looks like it should not break anything. If nobody complains before the next release, I'm going to merge this.

aminvakil
aminvakil approved these changes May 12, 2021
View reviewed changes
Copy link
Contributor

@aminvakil aminvakil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't use this module either, but change looks good to me.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label May 17, 2021
@felixfontein felixfontein merged commit 5b77515 into ansible-collections:main May 17, 2021
@patchback
Copy link

patchback bot commented May 17, 2021 •
edited
Loading

Backport to stable-2: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-2/5b7751530819ce066f8edf899ef3ecd2d7791e6d/pr-2495

Backported as #2527

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request May 17, 2021
@iridian-ks
1085 updating the hcl whitelist to include all supported options (#2495)
260f96c 
* 1085 updating the hcl whitelist to include all supported options

* Update changelogs/fragments/1085-consul-acl-hcl-whitelist-update.yml

Co-authored-by: Felix Fontein <[email protected]>

Co-authored-by: Dillon Gilmore <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit 5b77515)
@patchback patchback bot mentioned this pull request May 17, 2021
Merged
@patchback
Copy link

patchback bot commented May 17, 2021 •
edited
Loading

Backport to stable-3: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-3/5b7751530819ce066f8edf899ef3ecd2d7791e6d/pr-2495

Backported as #2528

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request May 17, 2021
@iridian-ks
1085 updating the hcl whitelist to include all supported options (#2495)
3ce0eae 
* 1085 updating the hcl whitelist to include all supported options

* Update changelogs/fragments/1085-consul-acl-hcl-whitelist-update.yml

Co-authored-by: Felix Fontein <[email protected]>

Co-authored-by: Dillon Gilmore <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit 5b77515)
@felixfontein
Copy link
Collaborator

@iridian-ks thanks for this fix!
@aminvakil thanks for reviewing!

@patchback patchback bot mentioned this pull request May 17, 2021
Merged
felixfontein pushed a commit that referenced this pull request May 17, 2021
@patchback @iridian-ks
1085 updating the hcl whitelist to include all supported options (#2495…
8ed5beb 
…) (#2527)

* 1085 updating the hcl whitelist to include all supported options

* Update changelogs/fragments/1085-consul-acl-hcl-whitelist-update.yml

Co-authored-by: Felix Fontein <[email protected]>

Co-authored-by: Dillon Gilmore <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit 5b77515)

Co-authored-by: iridian <[email protected]>
felixfontein pushed a commit that referenced this pull request May 17, 2021
@patchback @iridian-ks
1085 updating the hcl whitelist to include all supported options (#2495…
7753fa4 
…) (#2528)

* 1085 updating the hcl whitelist to include all supported options

* Update changelogs/fragments/1085-consul-acl-hcl-whitelist-update.yml

Co-authored-by: Felix Fontein <[email protected]>

Co-authored-by: Dillon Gilmore <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit 5b77515)

Co-authored-by: iridian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

@aminvakil aminvakil aminvakil approved these changes

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug clustering community_review has_issue module module needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI new_contributor Help guide this first time contributor plugins plugin (any type) stale_ci CI is older than 7 days, rerun before merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set session_prefix rule via consul_acl
5 participants
@iridian-ks @ansibullbot @felixfontein @aminvakil @dgilmor-rei