fix(keycloak_client): avoid TypeError if attributes is a list

As sanitize_cr might be executed after normalise_cr, result['attributes'] can be of type list and we run into: TypeError: list indices must be integers or slices, not str
ansible-collections · May 23, 2024 · 7e641d5 · 7e641d5
1 parent 4792e21
commit 7e641d5
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/changelogs/fragments/8403-fix-typeerror-in-keycloak-client.yaml b/changelogs/fragments/8403-fix-typeerror-in-keycloak-client.yaml
@@ -0,0 +1,2 @@
+bugfixes:
+  - keycloak_client - fix TypeError in sanitize_cr function. The function expected a dict where in some cases a list might occur (https://github.com/ansible-collections/community.general/pull/8403).
diff --git a/plugins/modules/keycloak_client.py b/plugins/modules/keycloak_client.py
@@ -775,8 +775,9 @@ def sanitize_cr(clientrep):
     if 'secret' in result:
         result['secret'] = 'no_log'
     if 'attributes' in result:
-        if 'saml.signing.private.key' in result['attributes']:
-            result['attributes']['saml.signing.private.key'] = 'no_log'
+        attributes = result['attributes']
+        if isinstance(attributes, dict) and 'saml.signing.private.key' in attributes:
+            attributes['saml.signing.private.key'] = 'no_log'
     return normalise_cr(result)
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		bugfixes:
		- keycloak_client - fix TypeError in sanitize_cr function. The function expected a dict where in some cases a list might occur (https://github.com/ansible-collections/community.general/pull/8403).