Add conversion filters for serial numbers #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docs Build 📝Thank you for contribution!✨ This PR has been merged and the docs are now incorporated into |
felixfontein
force-pushed
the
serial
branch
2 times, most recently
from
019bf61 to
84273cc
Compare
mariolenz
reviewed
Feb 18, 2024
There was a problem hiding this comment.
The documentation looks OK to me. Although I can't say if it really documents what the code does, or review the code changes themselves... I'm not really into this collection and would need some time to understand everything.
If it helps you: I didn't see any typos or something obviously problematic in the documentation.
|
@mariolenz thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Ref: #687.
ISSUE TYPE
COMPONENT NAME
parse_serial
to_serial