Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move licenses to LICENSES/, use SPDX-License-Identifier, mention all licenses in galaxy.yml #491

Merged
merged 15 commits into from
Jul 21, 2022
Merged

Move licenses to LICENSES/, use SPDX-License-Identifier, mention all licenses in galaxy.yml #491

merged 15 commits into from
Jul 21, 2022

Conversation

felixfontein
Copy link
Contributor

SUMMARY

Implements ansible-community/community-topics#112 (comment).

ISSUE TYPE
  • Docs Pull Request
  • Feature Pull Request
COMPONENT NAME

collection

@felixfontein
Copy link
Contributor Author

I created ansible/galaxy-importer#175 to address the failing galaxy import.

@felixfontein felixfontein changed the title Move licenses to LICENSES/, use SPDX-License-Identifier, mention all licenses in galaxy.yml [WIP] Move licenses to LICENSES/, use SPDX-License-Identifier, mention all licenses in galaxy.yml Jul 17, 2022
@felixfontein felixfontein changed the title [WIP] Move licenses to LICENSES/, use SPDX-License-Identifier, mention all licenses in galaxy.yml Move licenses to LICENSES/, use SPDX-License-Identifier, mention all licenses in galaxy.yml Jul 17, 2022
@felixfontein
Copy link
Contributor Author

@gotmax23 @briantist I've added BSD-3-Clause (with the license text from cryptography, which differs in two locations from the one on https://spdx.org/licenses/BSD-3-Clause: PyCA Cryptography instead of copyright holder in clause 3, and COPYRIGHT OWNER instead of COPYRIGHT HOLDER in the all-caps part), and also updated the README to mention all licenses.

@felixfontein
Copy link
Contributor Author

CI errors are unrelated.

@felixfontein
Copy link
Contributor Author

@briantist @gotmax23 any last words before merging this?

@felixfontein felixfontein merged commit 6bf3ef4 into ansible-collections:main Jul 21, 2022
@felixfontein felixfontein deleted the licenses branch July 21, 2022 05:27
@felixfontein
Copy link
Contributor Author

@gotmax23 @briantist thanks a lot for reviewing and all the feedback for all these licensing PRs! :)

@felixfontein felixfontein mentioned this pull request Aug 4, 2022
Open
This was referenced Aug 4, 2022
Merged
Merged
@renovate renovate bot mentioned this pull request Sep 29, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gotmax23 gotmax23 gotmax23 left review comments

@briantist briantist briantist approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felixfontein @briantist @gotmax23