Remove assertonly #289
Merged
Remove assertonly #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ready_for_review |
|
@MarkusTeufelberger @Ajpantuso would be great if you could take a look at this one. |
Ajpantuso
approved these changes
Oct 6, 2021
|
I'll merge this tomorrow (and rebase #290 and bump the galaxy.yml version in it). @MarkusTeufelberger if you want more time to look at this, please tell me before then, then I'll wait longer. |
|
I'm fine with it, but haven't looked deeply into the changes besides the changed lines. |
|
@Ajpantuso @MarkusTeufelberger thanks for reviewing this! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Removes the assertonly provider from x509_certificate.
This isn't complete yet, since some tests for other backends use assertonly as well.
ISSUE TYPE
COMPONENT NAME
x509_certificate