Relicense plugins/module_utils/acme.py under GPLv3+ #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code was originally licensed under GPLv3+ when being part of the letsencrypt module. It was relicensed under BSD 2-clause when moving to Ansible's module_utils (ansible/ansible#40697). The code was only touched by two persons (https://github.com/ansible/ansible/commits/pre-ansible-base/lib/ansible/module_utils/acme.py, https://github.com/ansible-collections/community.crypto/commits/main/plugins/module_utils/acme.py) and both persons consented in this PR (ansible-collections#165) before it was merged.
endorama
approved these changes
Jan 14, 2021
gundalow
approved these changes
Jan 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The code was originally licensed under GPLv3+ when being part of the letsencrypt module. It was relicensed under BSD 2-clause when moving to Ansible's module_utils (ansible/ansible#40697).
The code was only touched by two persons (https://github.com/ansible/ansible/commits/pre-ansible-base/lib/ansible/module_utils/acme.py, https://github.com/ansible-collections/community.crypto/commits/main/plugins/module_utils/acme.py), @endorama (for ansible/ansible@0d905a0) and me.
The main motivation for this re-license is to be able to do more refactoring of the ACME code, similar to the general crypto code, without having to split the result into two sets of files (one set GPL licensed, one set BSD licensed). Keeping everything BSD licensed would require to re-license some more code from the modules (which should go to module_utils) to BSD, which is quite an effort. Simply relicensing the module_utils code back to GPL is a lot easier since only two persons were involved with the code. Also this makes it easier to swap code between the ACME module utils and general crypto module utils, since these are also GPLv3+ licensed.
@endorama please review this PR and approve it if you agree to relicense your contribution in ansible/ansible@0d905a0 to the acme.py module_utils under GPLv3+.
CC @resmo @gundalow
ISSUE TYPE
COMPONENT NAME
plugins/module_utils/acme.py