openssl_pkcs12: Add a check for parsed pkcs12 files

[Normo]

SUMMARY

With this pull request the parse action for the openssl_pkcs12 module is now considered separately in the check() function.

Fixes #143

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

• openssl_pkcs12

ADDITIONAL INFORMATION

Without this change, the parse action would always result in changed state when running in check mode.

[felixfontein]

This is a bit messy, but the whole module is somewhat messy and needs a refactoring. So LGTM :)

Can you add a changelog fragment and add basic tests for this situation?

For tests, it probably makes sense to duplicate this: https://github.com/ansible-collections/community.crypto/blob/main/tests/integration/targets/openssl_pkcs12/tasks/impl.yml#L85-L90 register the result, and make sure in https://github.com/ansible-collections/community.crypto/blob/main/tests/integration/targets/openssl_pkcs12/tests/validate.yml that the task didn't change. Of course more extensive tests are also nice, but such a basic one would already be a big improvement!

[felixfontein]

And are you sure this is only a problem in check mode, and not also for regular mode? Glancing over the code, I guess both had this issue before (and your fix fixes both).

[Normo]

And are you sure this is only a problem in check mode, and not also for regular mode? Glancing over the code, I guess both had this issue before (and your fix fixes both).

Not quite! But 64890dd should now ensure that the correct state is also reported in normal mode (instead of always ok). I have adapted the changelog fragment for this purpose and provided a basic test.

@felixfontein Could you please review again?

[felixfontein]

LGTM

[felixfontein]

@Normo thanks a lot for fixing this!